From 5c86706f4ba3279a84aa463d4b7a4cf368397dc8 Mon Sep 17 00:00:00 2001 From: Houkime <> Date: Wed, 30 Nov 2022 16:41:20 +0000 Subject: [PATCH] Jobs: fix value access in is_busy() Also added a test for is_busy() that highlighted this bug. --- selfprivacy_api/jobs/__init__.py | 2 +- tests/test_jobs.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/selfprivacy_api/jobs/__init__.py b/selfprivacy_api/jobs/__init__.py index 6ad8493..4267819 100644 --- a/selfprivacy_api/jobs/__init__.py +++ b/selfprivacy_api/jobs/__init__.py @@ -182,7 +182,7 @@ class Jobs: Check if there is a job running. """ for job in Jobs.get_jobs(): - if job["status"] == JobStatus.RUNNING.value: + if job.status == JobStatus.RUNNING: return True return False diff --git a/tests/test_jobs.py b/tests/test_jobs.py index 7ef9a9b..3474fc3 100644 --- a/tests/test_jobs.py +++ b/tests/test_jobs.py @@ -33,6 +33,7 @@ def test_remove_update_nonexistent(jobs_with_one_job): def test_jobs(jobs_with_one_job): jobs = jobs_with_one_job test_job = jobs_with_one_job.get_jobs()[0] + assert not jobs.is_busy() jobs.update( job=test_job, @@ -44,6 +45,7 @@ def test_jobs(jobs_with_one_job): ) assert jobs.get_jobs() == [test_job] + assert jobs.is_busy() backup = jobsmodule.JOB_EXPIRATION_SECONDS jobsmodule.JOB_EXPIRATION_SECONDS = 0