From b2edfe784a30e1b125794a450a9cab6fa823b7b4 Mon Sep 17 00:00:00 2001
From: Houkime <>
Date: Mon, 18 Mar 2024 11:44:53 +0000
Subject: [PATCH] refactor(service): add return typing to DNSrecord conversion
 and comments

---
 selfprivacy_api/graphql/common_types/dns.py     | 1 +
 selfprivacy_api/graphql/common_types/service.py | 7 ++++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/selfprivacy_api/graphql/common_types/dns.py b/selfprivacy_api/graphql/common_types/dns.py
index 1c79036..f47daa8 100644
--- a/selfprivacy_api/graphql/common_types/dns.py
+++ b/selfprivacy_api/graphql/common_types/dns.py
@@ -2,6 +2,7 @@ import typing
 import strawberry
 
 
+# TODO: use https://strawberry.rocks/docs/integrations/pydantic when it is stable
 @strawberry.type
 class DnsRecord:
     """DNS record"""
diff --git a/selfprivacy_api/graphql/common_types/service.py b/selfprivacy_api/graphql/common_types/service.py
index 9ec1753..275c14c 100644
--- a/selfprivacy_api/graphql/common_types/service.py
+++ b/selfprivacy_api/graphql/common_types/service.py
@@ -89,9 +89,10 @@ def get_storage_usage(root: "Service") -> ServiceStorageUsage:
     )
 
 
-def service_dns_to_graphql(record: ServiceDnsRecord):
-    # Do we really need 2 types for this?
-    # ServiceDNSRecord and DnsRecord are almost identical
+# TODO: This won't be needed when deriving DnsRecord via strawberry pydantic integration
+# https://strawberry.rocks/docs/integrations/pydantic
+# Remove when the link above says it got stable.
+def service_dns_to_graphql(record: ServiceDnsRecord) -> DnsRecord:
     return DnsRecord(
         record_type=record.type,
         name=record.name,