From c5b227226c9d1d9ed0b79f328c0336c563b8ee2b Mon Sep 17 00:00:00 2001 From: Houkime <> Date: Mon, 18 Mar 2024 17:32:18 +0000 Subject: [PATCH] fix(backups): do not rely on obscure behaviour --- selfprivacy_api/backup/providers/__init__.py | 2 ++ tests/test_backup.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/selfprivacy_api/backup/providers/__init__.py b/selfprivacy_api/backup/providers/__init__.py index 4f8bb75..8cb2a74 100644 --- a/selfprivacy_api/backup/providers/__init__.py +++ b/selfprivacy_api/backup/providers/__init__.py @@ -21,6 +21,8 @@ PROVIDER_MAPPING: dict[BackupProviderEnum, Type[AbstractBackupProvider]] = { def get_provider( provider_type: BackupProviderEnum, ) -> Type[AbstractBackupProvider]: + if provider_type not in PROVIDER_MAPPING.keys(): + raise LookupError("could not look up provider", provider_type) return PROVIDER_MAPPING[provider_type] diff --git a/tests/test_backup.py b/tests/test_backup.py index 55741cc..b96f8e7 100644 --- a/tests/test_backup.py +++ b/tests/test_backup.py @@ -244,7 +244,7 @@ def test_error_censoring_loginkey(dummy_service, backups, fp): secret = "aSecretNYA" Backups.set_provider( - BackupProvider.BACKBLAZE, login="meow", key=secret, location="moon" + ProviderEnum.BACKBLAZE, login="meow", key=secret, location="moon" ) assert Backups.provider().key == secret