From de52dffddadab70dc09cf5fcd853324f215c9ad7 Mon Sep 17 00:00:00 2001
From: Houkime <>
Date: Wed, 23 Aug 2023 13:55:23 +0000
Subject: [PATCH] refactor(backups): a better backup-related service timeout
 error

---
 selfprivacy_api/services/service.py | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/selfprivacy_api/services/service.py b/selfprivacy_api/services/service.py
index e01501b..0f018b6 100644
--- a/selfprivacy_api/services/service.py
+++ b/selfprivacy_api/services/service.py
@@ -284,17 +284,23 @@ class StoppedService:
     def __enter__(self) -> Service:
         self.original_status = self.service.get_status()
         if self.original_status not in [ServiceStatus.INACTIVE, ServiceStatus.FAILED]:
-            self.service.stop()
-            wait_until_true(
-                lambda: self.service.get_status() == ServiceStatus.INACTIVE,
-                timeout_sec=DEFAULT_START_STOP_TIMEOUT,
-            )
+            try:
+                self.service.stop()
+                wait_until_true(
+                    lambda: self.service.get_status() == ServiceStatus.INACTIVE,
+                    timeout_sec=DEFAULT_START_STOP_TIMEOUT,
+                )
+            except TimeoutError as e:
+                raise TimeoutError(f"timed out waiting for {self.service.get_display_name()} to stop")
         return self.service
 
     def __exit__(self, type, value, traceback):
         if self.original_status in [ServiceStatus.ACTIVATING, ServiceStatus.ACTIVE]:
-            self.service.start()
-            wait_until_true(
-                lambda: self.service.get_status() == ServiceStatus.ACTIVE,
-                timeout_sec=DEFAULT_START_STOP_TIMEOUT,
-            )
+            try:
+                self.service.start()
+                wait_until_true(
+                    lambda: self.service.get_status() == ServiceStatus.ACTIVE,
+                    timeout_sec=DEFAULT_START_STOP_TIMEOUT,
+                )
+            except TimeoutError as e:
+                raise TimeoutError(f"timed out waiting for {self.service.get_display_name()} to start")