SelfPrivacy
/
selfprivacy-rest-api
7
2
Fork 1
Code Issues 15 Pull Requests 4 Projects Releases 1 Wiki Activity

Compatibility-breaking starlette 0.21 -> failing test_delete_token #16

New Issue
Closed
opened 2022-10-15 16:54:02 +03:00 by houkime · 9 comments
houkime commented 2022-10-15 16:54:02 +03:00
Collaborator

On master branch, 0a09a338b8
When running pytest

test_rest_endpoints/test_auth.py::test_delete_token - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
On master branch, 0a09a338b850704f221bd9b451519290584ef209 When running pytest ``` test_rest_endpoints/test_auth.py::test_delete_token - TypeError: TestClient.delete() got an unexpected keyword argument 'json' ```
houkime commented 2022-10-15 17:00:56 +03:00
Poster
Collaborator 
FAILED test_rest_endpoints/test_auth.py::test_delete_token - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/test_auth.py::test_delete_self_token - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/test_auth.py::test_delete_nonexistent_token - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/test_auth.py::test_get_and_delete_new_device_token - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/services/test_ssh.py::test_delete_root_key - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/services/test_ssh.py::test_delete_root_nonexistent_key - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/services/test_ssh.py::test_delete_root_key_on_undefined - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/services/test_ssh.py::test_delete_admin_key - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/services/test_ssh.py::test_delete_nonexistent_admin_key - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/services/test_ssh.py::test_delete_admin_key_on_undefined - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/services/test_ssh.py::test_delete_user_key - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/services/test_ssh.py::test_delete_nonexistent_user_key[2] - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/services/test_ssh.py::test_delete_nonexistent_user_key[3] - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/services/test_ssh.py::test_delete_keys_of_nonexistent_user - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
FAILED test_rest_endpoints/services/test_ssh.py::test_delete_key_when_undefined_users - TypeError: TestClient.delete() got an unexpected keyword argument 'json'
``` FAILED test_rest_endpoints/test_auth.py::test_delete_token - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/test_auth.py::test_delete_self_token - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/test_auth.py::test_delete_nonexistent_token - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/test_auth.py::test_get_and_delete_new_device_token - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/services/test_ssh.py::test_delete_root_key - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/services/test_ssh.py::test_delete_root_nonexistent_key - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/services/test_ssh.py::test_delete_root_key_on_undefined - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/services/test_ssh.py::test_delete_admin_key - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/services/test_ssh.py::test_delete_nonexistent_admin_key - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/services/test_ssh.py::test_delete_admin_key_on_undefined - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/services/test_ssh.py::test_delete_user_key - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/services/test_ssh.py::test_delete_nonexistent_user_key[2] - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/services/test_ssh.py::test_delete_nonexistent_user_key[3] - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/services/test_ssh.py::test_delete_keys_of_nonexistent_user - TypeError: TestClient.delete() got an unexpected keyword argument 'json' FAILED test_rest_endpoints/services/test_ssh.py::test_delete_key_when_undefined_users - TypeError: TestClient.delete() got an unexpected keyword argument 'json' ```
houkime commented 2022-10-15 17:04:56 +03:00
Poster
Collaborator

the offending lines

    response = authorized_client.delete(
        "/auth/tokens", json={"token_name": "test_token2"}
    )
the offending lines ``` response = authorized_client.delete( "/auth/tokens", json={"token_name": "test_token2"} ) ```
houkime commented 2022-10-15 17:08:10 +03:00
Poster
Collaborator

definition of the test client is in starlette package

    def delete(  # type: ignore[override]
        self,
        url: httpx._types.URLTypes,
        *,
        params: httpx._types.QueryParamTypes = None,
        headers: httpx._types.HeaderTypes = None,
        cookies: httpx._types.CookieTypes = None,
        auth: typing.Union[
            httpx._types.AuthTypes, httpx._client.UseClientDefault
        ] = httpx._client.USE_CLIENT_DEFAULT,
        follow_redirects: bool = None,
        allow_redirects: bool = None,
        timeout: typing.Union[
            httpx._client.TimeoutTypes, httpx._client.UseClientDefault
        ] = httpx._client.USE_CLIENT_DEFAULT,
        extensions: dict = None,
    ) -> httpx.Response:
        redirect = self._choose_redirect_arg(follow_redirects, allow_redirects)
        return super().delete(
            url,
            params=params,
            headers=headers,
            cookies=cookies,
            auth=auth,
            follow_redirects=redirect,
            timeout=timeout,
            extensions=extensions,
        )
definition of the test client is in `starlette` package ```python def delete( # type: ignore[override] self, url: httpx._types.URLTypes, *, params: httpx._types.QueryParamTypes = None, headers: httpx._types.HeaderTypes = None, cookies: httpx._types.CookieTypes = None, auth: typing.Union[ httpx._types.AuthTypes, httpx._client.UseClientDefault ] = httpx._client.USE_CLIENT_DEFAULT, follow_redirects: bool = None, allow_redirects: bool = None, timeout: typing.Union[ httpx._client.TimeoutTypes, httpx._client.UseClientDefault ] = httpx._client.USE_CLIENT_DEFAULT, extensions: dict = None, ) -> httpx.Response: redirect = self._choose_redirect_arg(follow_redirects, allow_redirects) return super().delete( url, params=params, headers=headers, cookies=cookies, auth=auth, follow_redirects=redirect, timeout=timeout, extensions=extensions, ) ```
houkime commented 2022-10-15 17:21:00 +03:00
Poster
Collaborator

0.21.0 of starlette has landed 19 days ago and was a compatibility breaking release.
they provide a migration tool to make un-breaking the tests easier.
https://github.com/encode/starlette/releases/tag/0.21.0

0.21.0 of starlette has landed 19 days ago and was a compatibility breaking release. they provide a migration tool to make un-breaking the tests easier. https://github.com/encode/starlette/releases/tag/0.21.0
houkime changed title from Failing test_delete_token to Compatibility-breaking starlette 0.21 -> failing test_delete_token 2022-10-15 17:24:12 +03:00
def self-assigned this 2022-10-15 18:52:31 +03:00
inex was assigned by def 2022-10-15 18:52:44 +03:00
houkime commented 2022-10-15 19:25:36 +03:00
Poster
Collaborator

The unbreaking tool works, so migrating tests is not the problem.
However, one needs to sync this change of tests with bumping statlette in nix.
Bumping starlette will require bumping python because there are no newer typing-extensions for python 3.9

The unbreaking tool works, so migrating tests is not the problem. However, one needs to sync this change of tests with bumping statlette in nix. Bumping starlette will require bumping python because there are no newer typing-extensions for python 3.9
houkime commented 2022-10-15 19:32:06 +03:00
Poster
Collaborator

bumping python to 3.10 passes this obstacle but is blocked by anyio

No matching distribution found for anyio<5,>=3.4.0
bumping python to 3.10 passes this obstacle but is blocked by anyio ``` No matching distribution found for anyio<5,>=3.4.0 ```
inex commented 2022-10-17 21:05:41 +03:00
Owner

0.21 version didn't land to NixOS yet. Error didn't show up on nixpkgs-unstable branch.

Starlette upgrade is pending on https://github.com/NixOS/nixpkgs/pull/193923

I guess we have to wait right now.

0.21 version didn't land to NixOS yet. Error didn't show up on nixpkgs-unstable branch. Starlette upgrade is pending on https://github.com/NixOS/nixpkgs/pull/193923 I guess we have to wait right now.
houkime commented 2023-06-21 15:43:29 +03:00
Poster
Collaborator

starlette is now 0.26 in 23.05 release of nix-pkgs
4ecab32735/pkgs/development/python-modules/starlette

starlette is now 0.26 in 23.05 release of nix-pkgs https://github.com/NixOS/nixpkgs/tree/4ecab3273592f27479a583fb6d975d4aba3486fe/pkgs/development/python-modules/starlette
NaiJi added the
Bug
 label 2023-07-12 17:56:00 +03:00
houkime commented 2024-03-15 12:13:48 +02:00
Poster
Collaborator

Starlette is now 0.31 and we use it this way.

Starlette is now 0.31 and we use it this way.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
pytest-no-v
coverage-for-sonar-2
coverage-for-sonar
def/nix-collect-garbage-endpoint
inex/other-server-provider
master
redis-huey
censor-errors
rebuild-when-moving
ci-vm-for-pytest
vm-disk
inex/test-autobackup-fix
test-migration
not-autobackup-disabled
remove-rest
flakes
autobackup-errors
mountchecks-logged
backups-forget
backups-unlock
redis/connection-pool
restic-rewrite-api
l10n
providers/digital-ocan-dns
redis/rest-tests
redis/token-repo
redis-experiments
def_tests2
def_tests
graphql
test-branch
backups-fix
3.0.1
v.1.0.1
Labels
Clear labels   
Bug
   
Contributions welcome
   
Did not do
   
Duplicate
   
Feature
  
Module
Backups
   
Module
GraphQL
  
Priority
High
   
Priority
Low
   
Priority
Medium
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
No Label
Bug
Contributions welcome
Did not do
Duplicate
Feature
Module
Backups
Module
GraphQL
Priority
High
Priority
Low
Priority
Medium
Refactor
Severity
High
Severity
Low
Severity
Medium
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
inex
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy-rest-api#16
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?