SelfPrivacy
/
selfprivacy-rest-api
7
2
Fork 1
Code Issues 15 Pull Requests 3 Projects Releases 1 Wiki Activity

Server deletes snapshots during set_autobackup_quotas request #71

New Issue
Closed
opened 2023-11-17 12:42:33 +02:00 by inex · 1 comment
inex commented 2023-11-17 12:42:33 +02:00
Owner

Expected Behavior

When setting a new quota, server should start deleting snapshots in the background, and return the response to the client fast.

Actual Behavior

When setting a new quota that implied deleting ~80 snapshots, the server just hang up and the client timed out. Further requests were not processed in time.

Steps to Reproduce

  1. Set unlimited quotas
  2. Have dozens of snapshots created in one day
  3. Set a daily quota to 1
  4. ???
  5. Timed out, or the response received after too much time.

Context and notes

I think this is caused by this code

### Expected Behavior When setting a new quota, server should start deleting snapshots in the background, and return the response to the client fast. ### Actual Behavior When setting a new quota that implied deleting ~80 snapshots, the server just hang up and the client timed out. Further requests were not processed in time. ### Steps to Reproduce 1. Set unlimited quotas 2. Have dozens of snapshots created in one day 3. Set a daily quota to 1 4. ??? 5. Timed out, or the response received after too much time. ### Context and notes I think this is caused by [this code](https://git.selfprivacy.org/SelfPrivacy/selfprivacy-rest-api/src/commit/113bcf4c29371a249425b90e8d872a84f234457d/selfprivacy_api/backup/__init__.py#L430)
inex added the
Bug
 label 2023-11-17 12:42:33 +02:00
houkime was assigned by inex 2023-11-17 12:42:33 +02:00
inex changed title from Server deletes snapshots during set_autobackup_quotas requeste to Server deletes snapshots during set_autobackup_quotas request 2023-11-17 12:43:46 +02:00
houkime commented 2024-03-06 12:54:16 +02:00
Collaborator

Was addressed by f1a452009a

Was addressed by https://git.selfprivacy.org/SelfPrivacy/selfprivacy-rest-api/commit/f1a452009a13d8e1f5720ac03d5a452b3be21176
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
def/nix-collect-garbage-endpoint
pytest-no-v
coverage-for-sonar-2
coverage-for-sonar
inex/other-server-provider
redis-huey
censor-errors
rebuild-when-moving
ci-vm-for-pytest
vm-disk
inex/test-autobackup-fix
test-migration
not-autobackup-disabled
remove-rest
flakes
autobackup-errors
mountchecks-logged
backups-forget
backups-unlock
redis/connection-pool
restic-rewrite-api
l10n
providers/digital-ocan-dns
redis/rest-tests
redis/token-repo
redis-experiments
def_tests2
def_tests
graphql
test-branch
backups-fix
3.0.1
v.1.0.1
Labels
Clear labels   
Bug
   
Contributions welcome
   
Did not do
   
Duplicate
   
Feature
  
Module
Backups
   
Module
GraphQL
  
Priority
High
   
Priority
Low
   
Priority
Medium
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
No Label
Bug
Contributions welcome
Did not do
Duplicate
Feature
Module
Backups
Module
GraphQL
Priority
High
Priority
Low
Priority
Medium
Refactor
Severity
High
Severity
Low
Severity
Medium
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
houkime
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy-rest-api#71
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?