SelfPrivacy
/
selfprivacy-rest-api
7
2
Fork 1
Code Issues 15 Pull Requests 4 Projects Releases 1 Wiki Activity

delete-snapshot-batching #73

Merged
inex merged 7 commits from delete-snapshot-batching into master 2023-11-20 14:01:53 +02:00
Conversation 0 Commits 7 Files Changed 8
houkime commented 2023-11-17 17:54:41 +02:00
Collaborator
  • add better support for mass-removinng snapshots
  • make trimming the snapshots asynchronous
* add better support for mass-removinng snapshots * make trimming the snapshots asynchronous
houkime added 6 commits 2023-11-17 17:54:42 +02:00
continuous-integration/drone/push Build is failing Details
f1a452009a refactor(backups): only async snapshot trimming
continuous-integration/drone/push Build is failing Details
4339c00058 test(backups): test the trimming task
inex reviewed 2023-11-17 18:09:06 +02:00
selfprivacy_api/backup/__init__.py Outdated
@ -397,9 +397,8 @@ class Backups:
# TODO: Can be optimized since there is forgetting of an array in one restic op
inex commented 2023-11-17 18:01:16 +02:00
Owner

TODO can be removed

TODO can be removed
inex marked this conversation as resolved
selfprivacy_api/backup/__init__.py Outdated
@ -617,8 +632,7 @@ class Backups:
"""deliberately erase all snapshots we made"""
# there is no dedicated optimized command for this,
inex commented 2023-11-17 18:03:09 +02:00
Owner

dead comment?

dead comment?
inex marked this conversation as resolved
selfprivacy_api/backup/tasks.py
@ -7,0 +6,4 @@
from selfprivacy_api.graphql.common_types.backup import (
RestoreStrategy,
BackupReason,
AutobackupQuotas,
inex commented 2023-11-17 18:06:58 +02:00
Owner

Unused import

Unused import
inex marked this conversation as resolved
selfprivacy_api/graphql/mutations/backup_mutations.py Outdated
@ -104,2 +110,4 @@
"""
job = Jobs.add(
name="trimming autobackup snapshots",
inex commented 2023-11-17 18:08:30 +02:00
Owner

Should start with a capital letter

Should start with a capital letter
inex marked this conversation as resolved
houkime added 1 commit 2023-11-20 13:30:53 +02:00
continuous-integration/drone/push Build is failing Details
993b58d52d beauty(backup): remove stray comments and imports, format
inex approved these changes 2023-11-20 13:38:05 +02:00
inex merged commit 860071e046 into master 2023-11-20 14:01:53 +02:00
inex deleted branch delete-snapshot-batching 2023-11-20 14:01:53 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
inex
Labels
Clear labels   
Bug
   
Contributions welcome
   
Did not do
   
Duplicate
   
Feature
  
Module
Backups
   
Module
GraphQL
  
Priority
High
   
Priority
Low
   
Priority
Medium
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
No Label
Bug
Contributions welcome
Did not do
Duplicate
Feature
Module
Backups
Module
GraphQL
Priority
High
Priority
Low
Priority
Medium
Refactor
Severity
High
Severity
Low
Severity
Medium
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy-rest-api#73
There is no content yet.
Delete Branch "delete-snapshot-batching"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?