SelfPrivacy
/
selfprivacy-rest-api
7
2
Fork 1
Code Issues 15 Pull Requests 3 Projects Releases 1 Wiki Activity

Provide display name for DNS records from the server #75

New Issue
Closed
opened 2023-11-22 13:23:56 +02:00 by NaiJi · 2 comments
NaiJi commented 2023-11-22 13:23:56 +02:00
Collaborator

image

Our server does not provide readable descriptions or any other kind of conventional naming for DNS records, which wasn't a problem until now. But as we remove hardcode of desired DNS records and rely solely on what server provides, it is not possible (or is impractical) to determine description on the client end for every received record.

Suggestion:

  • Add a displayName: str field for ServiceDnsRecord class
![image](/attachments/ebb96337-2b90-4fde-8383-0426468113c5) Our server does not provide readable descriptions or any other kind of conventional naming for DNS records, which wasn't a problem until now. But as we [remove](https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/265) hardcode of desired DNS records and rely solely on what server provides, it is not possible (or is impractical) to determine description on the client end for every received record. Suggestion: - Add a `displayName: str` field for `ServiceDnsRecord` class
👍 1
NaiJi added the
Feature
Module
GraphQL
 labels 2023-11-22 13:23:56 +02:00
NaiJi changed title from Provide descriptions for DNS records from the server to Provide display name for DNS records from the server 2023-11-22 13:25:38 +02:00
inex commented 2023-12-12 07:03:58 +02:00
Owner

Implemented in master, waiting for the next release.

Implemented in master, waiting for the next release.
inex commented 2023-12-28 15:21:22 +02:00
Owner

Published in 2.4.3

Published in 2.4.3
inex closed this issue 2023-12-28 15:21:22 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
def/nix-collect-garbage-endpoint
pytest-no-v
coverage-for-sonar-2
coverage-for-sonar
inex/other-server-provider
redis-huey
censor-errors
rebuild-when-moving
ci-vm-for-pytest
vm-disk
inex/test-autobackup-fix
test-migration
not-autobackup-disabled
remove-rest
flakes
autobackup-errors
mountchecks-logged
backups-forget
backups-unlock
redis/connection-pool
restic-rewrite-api
l10n
providers/digital-ocan-dns
redis/rest-tests
redis/token-repo
redis-experiments
def_tests2
def_tests
graphql
test-branch
backups-fix
3.0.1
v.1.0.1
Labels
Clear labels   
Bug
   
Contributions welcome
   
Did not do
   
Duplicate
   
Feature
  
Module
Backups
   
Module
GraphQL
  
Priority
High
   
Priority
Low
   
Priority
Medium
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
No Label
Bug
Contributions welcome
Did not do
Duplicate
Feature
Module
Backups
Module
GraphQL
Priority
High
Priority
Low
Priority
Medium
Refactor
Severity
High
Severity
Low
Severity
Medium
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy-rest-api#75
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?