SelfPrivacy
/
selfprivacy-rest-api
7
2
Fork 1
Code Issues 15 Pull Requests 4 Projects Releases 1 Wiki Activity

WIP: test: add storage & services tests #17

Closed
def wants to merge 6 commits from def_tests2 into master
pull from: def_tests2
merge into: SelfPrivacy:master
Conversation 2 Commits 6 Files Changed 4
def commented 2022-10-17 14:16:44 +03:00
Collaborator
There is no content yet.
👀 1
inex was assigned by def 2022-10-17 14:16:44 +03:00
def added 2 commits 2022-10-17 14:16:45 +03:00
NaiJi commented 2022-10-17 20:50:21 +03:00
Collaborator

What about commits convention? 👁️

What about commits [convention](https://www.conventionalcommits.org/en/v1.0.0/)? 👁️
def changed title from WIP: def_tests2 to WIP: test: add storage & services tests 2022-10-18 13:51:33 +03:00
def added 1 commit 2022-10-21 19:37:48 +03:00
def requested review from inex 2022-10-21 19:47:52 +03:00
def added 2 commits 2022-10-21 20:06:39 +03:00
def added 1 commit 2022-10-23 20:44:37 +03:00
inex requested changes 2022-10-28 17:07:46 +03:00
inex left a comment
Owner

Duplicating tests, check you coverage.

Duplicating tests, check you coverage.
tests/test_graphql/test_api_services.py
@ -0,0 +574,4 @@
assert response.json()["data"]["moveService"]["success"] is False
def test_graphql_move_service_volume_not_found(
inex commented 2022-10-23 20:51:08 +03:00
Owner

This test is broken: gets 404 because the service not found, not the volume not found

This test is broken: gets 404 because the service not found, not the volume not found
inex was unassigned by def 2022-12-13 01:13:03 +02:00
def self-assigned this 2022-12-13 01:13:03 +02:00
def removed their assignment 2024-02-05 02:38:41 +02:00
houkime was assigned by def 2024-02-05 02:38:41 +02:00
houkime commented 2024-03-06 12:56:37 +02:00
Collaborator

Superseded by #88

Superseded by https://git.selfprivacy.org/SelfPrivacy/selfprivacy-rest-api/pulls/88
houkime closed this pull request 2024-03-06 12:56:37 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
inex
Labels
Clear labels   
Bug
   
Contributions welcome
   
Did not do
   
Duplicate
   
Feature
  
Module
Backups
   
Module
GraphQL
  
Priority
High
   
Priority
Low
   
Priority
Medium
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
No Label
Bug
Contributions welcome
Did not do
Duplicate
Feature
Module
Backups
Module
GraphQL
Priority
High
Priority
Low
Priority
Medium
Refactor
Severity
High
Severity
Low
Severity
Medium
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
houkime
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy-rest-api#17
There is no content yet.
Delete Branch "def_tests2"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?