SelfPrivacy
/
selfprivacy-rest-api
7
2
Fork 1
Code Issues 15 Pull Requests 4 Projects Releases 1 Wiki Activity

redis/jobs-coverage #24

Merged
inex merged 10 commits from redis/jobs-coverage into redis/connection-pool 2022-12-02 13:01:10 +02:00
Conversation 0 Commits 10 Files Changed 2
houkime commented 2022-11-30 19:42:28 +02:00
Collaborator

Wrote tests.
Fixed 2 bugs in the process.
Code coverage (with branches) of job__init__.py rose from 81% to 99%

Wrote tests. Fixed 2 bugs in the process. Code coverage (with branches) of job__init__.py rose from 81% to 99%
houkime added 10 commits 2022-11-30 19:42:29 +02:00
106a083ca2 jobs: simplify reset 
Also ups test coverage
14c4ae26ab explicitly mark helper functions private 
I thought about making them private class members, but that would get
unreadable and do more harm than good.
5c86706f4b Jobs: fix value access in is_busy() 
Also added a test for is_busy() that highlighted this bug.
063dfafc19 Jobs: fix return value of remove_by_uid 
And add a test for said return value.
houkime requested review from inex 2022-11-30 19:42:42 +02:00
inex merged commit 9cf4d46c50 into redis/connection-pool 2022-12-02 13:01:10 +02:00
inex deleted branch redis/jobs-coverage 2022-12-02 13:01:10 +02:00
inex referenced this issue from a commit 2022-12-02 13:01:11 +02:00
redis/jobs-coverage (#24)
Sign in to join this conversation.
Reviewers
No reviewers
inex
Labels
Clear labels   
Bug
   
Contributions welcome
   
Did not do
   
Duplicate
   
Feature
  
Module
Backups
   
Module
GraphQL
  
Priority
High
   
Priority
Low
   
Priority
Medium
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
No Label
Bug
Contributions welcome
Did not do
Duplicate
Feature
Module
Backups
Module
GraphQL
Priority
High
Priority
Low
Priority
Medium
Refactor
Severity
High
Severity
Low
Severity
Medium
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy-rest-api#24
There is no content yet.
Delete Branch "redis/jobs-coverage"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?