From 40c423437a89eba29b1b7850c3d073c641745a0a Mon Sep 17 00:00:00 2001 From: NaiJi Date: Fri, 19 Jan 2024 17:23:09 +0400 Subject: [PATCH] refactor: Rename variables and add needed comments - https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/265 --- lib/logic/providers/dns_providers/cloudflare.dart | 6 +++--- lib/utils/network_utils.dart | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/logic/providers/dns_providers/cloudflare.dart b/lib/logic/providers/dns_providers/cloudflare.dart index 870a0cb7..e40292a9 100644 --- a/lib/logic/providers/dns_providers/cloudflare.dart +++ b/lib/logic/providers/dns_providers/cloudflare.dart @@ -133,10 +133,10 @@ class CloudflareDnsProvider extends DnsProvider { /// Remove all records that do not match with SelfPrivacy cloudflareRecords.removeWhere( - (final oceanRecord) => !selfprivacyRecords.any( + (final cloudflareRecord) => !selfprivacyRecords.any( (final selfprivacyRecord) => - selfprivacyRecord.type == oceanRecord.type && - selfprivacyRecord.name == oceanRecord.name, + selfprivacyRecord.type == cloudflareRecord.type && + selfprivacyRecord.name == cloudflareRecord.name, ), ); diff --git a/lib/utils/network_utils.dart b/lib/utils/network_utils.dart index a7dc874e..c155d6a0 100644 --- a/lib/utils/network_utils.dart +++ b/lib/utils/network_utils.dart @@ -122,6 +122,9 @@ List getProjectDnsRecords( ttl: 18000, ); + /// We never create this record! + /// This declaration is only for removal + /// as we need to compare by 'type' and 'name' final DnsRecord txt3 = DnsRecord( type: 'TXT', name: 'selector._domainkey',