• Joined on 2022-10-14
Loading Heatmap…

houkime pushed to autobackup-errors at SelfPrivacy/selfprivacy-rest-api

2023-11-10 19:10:26 +02:00

houkime created pull request SelfPrivacy/selfprivacy-rest-api#69

fix(backups): do not infinitely retry automatic backup if it errors out

2023-11-07 03:16:43 +02:00

houkime created branch autobackup-errors in SelfPrivacy/selfprivacy-rest-api

2023-11-07 03:16:13 +02:00

houkime pushed to autobackup-errors at SelfPrivacy/selfprivacy-rest-api

  • fc2f6d97a3 fix(backups): do not infinitely retry automatic backup if it errors out

2023-11-07 03:16:13 +02:00

houkime pushed to redis/connection-pool-merged at SelfPrivacy/selfprivacy-rest-api

  • a66ee2d3e5 test(auth): fix future expiring too fast

2023-11-01 18:48:47 +02:00

houkime pushed to redis/connection-pool-merged at SelfPrivacy/selfprivacy-rest-api

  • 3deaeb28c5 test(auth): fix assert_ok's wrt nested structure

2023-11-01 17:31:31 +02:00

houkime pushed to redis/connection-pool-merged at SelfPrivacy/selfprivacy-rest-api

2023-10-25 17:54:24 +03:00

houkime pushed to remove-rest at SelfPrivacy/selfprivacy-rest-api

2023-10-11 21:31:25 +03:00

houkime commented on pull request SelfPrivacy/selfprivacy-rest-api#21

add nix-collect-garbage endpoint

what are you trying to do here exactly?

2023-09-27 19:42:36 +03:00

houkime commented on pull request SelfPrivacy/selfprivacy-rest-api#21

add nix-collect-garbage endpoint

Add typing to functions

2023-09-27 19:28:53 +03:00

houkime commented on pull request SelfPrivacy/selfprivacy-rest-api#21

add nix-collect-garbage endpoint

You mean some very specific type of line here. Please, paste an example as a docstring and maybe rename function for clarity

2023-09-27 19:28:53 +03:00

houkime commented on pull request SelfPrivacy/selfprivacy-rest-api#21

add nix-collect-garbage endpoint

You can pass job as an argument to a function to not have these complex resturns

2023-09-27 19:28:53 +03:00

houkime commented on pull request SelfPrivacy/selfprivacy-rest-api#21

add nix-collect-garbage endpoint

Consider renaming to `process_stream`.

2023-09-27 19:28:53 +03:00

houkime commented on pull request SelfPrivacy/selfprivacy-rest-api#21

add nix-collect-garbage endpoint

There is `JobStatus.Error`, please use it

2023-09-27 19:28:53 +03:00

houkime commented on pull request SelfPrivacy/selfprivacy-rest-api#21

add nix-collect-garbage endpoint

In current version of jobs, it is not necessary to set progress to 100 explicitly when finishing the job

2023-09-27 19:28:53 +03:00

houkime commented on pull request SelfPrivacy/selfprivacy-rest-api#21

add nix-collect-garbage endpoint

`is True` already checks that it is a boolean and it is True

2023-09-27 19:28:53 +03:00

houkime commented on pull request SelfPrivacy/selfprivacy-rest-api#21

add nix-collect-garbage endpoint

This is not a query, this is a Mutation. Both semantically and you wrote it yourself.

2023-09-27 19:28:53 +03:00

houkime commented on pull request SelfPrivacy/selfprivacy-rest-api#21

add nix-collect-garbage endpoint

Here you wrote that it is a mutation, but you test it as a query.

2023-09-27 19:28:53 +03:00

houkime suggested changes for SelfPrivacy/selfprivacy-rest-api#21

add nix-collect-garbage endpoint

2023-09-27 19:28:53 +03:00

houkime created pull request SelfPrivacy/selfprivacy-rest-api#62

autobackup-job-ttl

2023-09-22 21:15:43 +03:00