SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 79 Pull Requests 4 Projects 1 Releases 24 Wiki Activity

feat: Add refresh indicator on Recovery Key page to support drag gestures #148

Merged
inex merged 1 commits from recovery-keys into master 2022-11-22 14:07:24 +02:00
Conversation 0 Commits 1 Files Changed 1
NaiJi commented 2022-11-21 11:14:48 +02:00
Collaborator

It was impossible to forcefully request updates on recovery key status (issue 147). Now it is wrapped with drag gesture handler to force information fetching from server.

It was impossible to forcefully request updates on recovery key status (issue [147](https://git.selfprivacy.org/kherel/selfprivacy.org.app/issues/147)). Now it is wrapped with drag gesture handler to force information fetching from server.
NaiJi added the
Bug
 label 2022-11-21 11:14:48 +02:00
NaiJi self-assigned this 2022-11-21 11:14:48 +02:00
NaiJi requested review from inex 2022-11-21 11:14:54 +02:00
inex requested changes 2022-11-21 14:41:22 +02:00
lib/ui/pages/recovery_key/recovery_key.dart Outdated
@ -24,2 +25,4 @@
@override
Widget build(final BuildContext context) {
if (!loadedOnOpening) {
inex commented 2022-11-21 14:41:19 +02:00
Owner

Something feels wrong with this approach.

If you want to do something on the first draw, you use initState. Example here. Documentation.

I don't see why we need this loadedOnOpening bool variable. If you just need to ping cubit on the page entry, use initState.

Something feels wrong with this approach. If you want to do something on the first draw, you use initState. [Example here](https://git.selfprivacy.org/kherel/selfprivacy.org.app/src/branch/master/lib/ui/components/brand_tab_bar/brand_tab_bar.dart#L15). [Documentation](https://api.flutter.dev/flutter/widgets/State/initState.html). I don't see why we need this `loadedOnOpening` bool variable. If you just need to ping cubit on the page entry, use initState.
NaiJi commented 2022-11-21 15:04:31 +02:00
Poster
Collaborator

But initState doesn't have context. This is essentially the same thing as this check.

But initState doesn't have context. This is essentially the same thing as [this check](https://git.selfprivacy.org/kherel/selfprivacy.org.app/src/commit/0639ee4d57317b5c9d045287b297c5e8b43f6445/lib/ui/pages/server_storage/binds_migration/migration_process_page.dart#L32).
NaiJi commented 2022-11-21 15:06:07 +02:00
Poster
Collaborator

Oops, no, wrong link, but you get what I wanted to say.

Oops, no, wrong link, but you get what I wanted to say.
NaiJi requested review from inex 2022-11-21 15:05:04 +02:00
NaiJi changed title from feat: Add refresh indicator on Recovery Key page to support drag gestures to WIP: feat: Add refresh indicator on Recovery Key page to support drag gestures 2022-11-21 15:18:09 +02:00
NaiJi force-pushed recovery-keys from 79f69cb1cd to 3ba2c6f731 2022-11-21 15:19:21 +02:00 Compare
NaiJi changed title from WIP: feat: Add refresh indicator on Recovery Key page to support drag gestures to feat: Add refresh indicator on Recovery Key page to support drag gestures 2022-11-21 15:43:41 +02:00
inex approved these changes 2022-11-22 14:07:14 +02:00
inex merged commit 32ca58537e into master 2022-11-22 14:07:24 +02:00
inex deleted branch recovery-keys 2022-11-22 14:07:24 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
inex
Labels
Clear labels   
Blocked

Issue that can't be resolved right now due to some circumstances   
Bug

Discovered issue that affects regular operation   
Contributions welcome
   
Did not do

Issue is not queued for resolution due to low priority or introduced difficulties during the resolution   
Errata

Known issue with available workaround   
Feature request

Functionality/usability enchansement   
Fixed

Issue resolved in one of the application/backend releases   
How To

Question, regarding product operation   
Invalid
   
Needs design

A sketch or detailed description of the feature look is wanted   
No resolution

Issue is not queued for resolution due to architecture pecularities
  
Priority
Critical
   
Priority
High
   
Priority
Low
   
Priority
Medium
  
Providers
Digital Ocean
Issues related to Digital Ocean REST API   
Providers
Hetzner
Issues related to Hetzner REST API
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
  
Source
Community
Feature requests and bugs reported on our support chats   
Source
Core Team
   
Source
Stakeholders
Kirill, NLnet, and others
  
Translations
   
Under investigation

Issue details are currently being investigated
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
NaiJi
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#148
There is no content yet.
Delete Branch "recovery-keys"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?