Strings fetched from the server are not translated

def commented

2023-01-02 03:26:19 +02:00

Collaborator

![image](/attachments/222564b6-4762-4eb9-8552-2861ca8fae6b)

image.png

167 KiB

def added the

Bug

Priority

Medium

labels 2023-01-02 03:26:19 +02:00

NaiJi was assigned by def

2023-01-02 03:27:02 +02:00

inex commented

2023-01-02 06:08:23 +02:00

Owner

These are fetched from the server, i18n has to be implemented at the API level.

NaiJi was unassigned by inex

2023-01-04 11:26:36 +02:00

inex removed the

Bug

label 2023-01-04 11:26:40 +02:00

inex changed title from ~~Translation errors~~ to Strings fetched from the server are not translated

2023-01-04 11:26:57 +02:00

NaiJi commented

2023-07-26 18:02:48 +03:00

Collaborator

Related issue: 205.
Is partially pending on: PR 243.

Related issue: [205](https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/205). Is partially pending on: [PR 243](https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/pulls/243).

NaiJi referenced this issue

2023-07-26 18:03:40 +03:00

Pass current locale to the API #205

houkime commented

2023-07-28 18:58:38 +03:00

Collaborator

Why exactly are they fetched from the server at all?
If these are static explainers, they should be a part of app interface with all the translations I think.

Why exactly are they fetched from the server at all? If these are *static* explainers, they should be a part of app interface with all the translations I think.

inex commented

2023-07-28 20:02:52 +03:00

Owner

They are not static from the app POV. There is no point of updating the app every time we add a new service or change something in API.

NaiJi commented

2023-07-28 20:06:11 +03:00

Collaborator

Funny enough that the only translated part on the OP screenshot is TODO-covered with this exact issue

/// TODO Turn loginInfo into dynamic data, not static!
  String get loginInfo {
    switch (id) {
      case 'mailserver':
        return 'mail.login_info'.tr();
      case 'bitwarden':
        return 'password_manager.login_info'.tr();
      . . .
    }
    return '';
  }

Funny enough that the only translated part on the OP screenshot is TODO-covered with this exact issue ```dart /// TODO Turn loginInfo into dynamic data, not static! String get loginInfo { switch (id) { case 'mailserver': return 'mail.login_info'.tr(); case 'bitwarden': return 'password_manager.login_info'.tr(); . . . } return ''; } ```

def commented

2023-08-30 16:34:03 +03:00

Poster

Collaborator

what the status?

def added

and removed