houkime-providers-api #19
No reviewers
Labels
No Label
Bug
Contributions welcome
Did not do
Duplicate
Feature
Module
Backups
Module
GraphQL
Priority
High
Priority
Low
Priority
Medium
Refactor
Severity
High
Severity
Low
Severity
Medium
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: SelfPrivacy/selfprivacy-rest-api#19
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "houkime/selfprivacy-rest-api:houkime-providers-api"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
Migration to
format in userdata.json and corresponding changes to methods and tests.
@ -26,2 +27,4 @@
MountVolume(),
CheckForFailedBindsMigration(),
CreateProviderFields(),
Please reformat code with
black .
before commiting final versionaddressed
@ -45,6 +48,7 @@ def run_migrations():
return
for migration in migrations:
print ("starting migration:", migration)
Please remove this print in final revision
addressed
@ -265,3 +266,3 @@
@router.put("/restic/backblaze/config")
async def set_backblaze_config(backblaze_config: BackblazeConfigInput):
async def set_backblaze_config(backup_config: BackupConfigInput):
This is a breaking API change.
REST API is deprecated and should keep the same interface until we delete it. Here, we should use the original API model and just imply (hardcode) backblaze.
I kept the
backup
internal name since it does not technically change the interface. Please tell me if it is not ok.I did hardcode backblaze and no longer require the provider field as requested.
@ -459,3 +461,3 @@
response = authorized_client.put(
"/services/restic/backblaze/config",
json={"accountId": "123", "accountKey": "456", "bucket": "789"},
json={"provider": "IDRIVE", "accountId": "123", "accountKey": "456", "bucket": "789"},
The client won't have this input updated, we should test without provider field.
GraphQL will have the interface for the provider.
addressed, also see above
c1db1f67e9
to41e5f89b7b
WIP: houkime-providers-apito houkime-providers-api