SelfPrivacy
/
selfprivacy-rest-api
7
2
Fork 1
Code Issues 15 Pull Requests 4 Projects Releases 1 Wiki Activity

houkime-providers-api #19

Merged
inex merged 14 commits from houkime/selfprivacy-rest-api:houkime-providers-api into redis/connection-pool 2022-11-02 17:35:59 +02:00
Conversation 0 Commits 14 Files Changed 56
houkime commented 2022-10-31 19:04:25 +02:00
Collaborator

Migration to

    "dns": {
        "provider": "CLOUDFLARE",
        "apiKey": "TOKEN"
    },
    "server": {
        "provider": "HETZNER"
    },
    "backup": {
        "provider": "BACKBLAZE",
        "accountId": "ID",
        "accountKey": "KEY",
        "bucket": "selfprivacy"
    }

format in userdata.json and corresponding changes to methods and tests.

Migration to ``` "dns": { "provider": "CLOUDFLARE", "apiKey": "TOKEN" }, "server": { "provider": "HETZNER" }, "backup": { "provider": "BACKBLAZE", "accountId": "ID", "accountKey": "KEY", "bucket": "selfprivacy" } ``` format in userdata.json and corresponding changes to methods and tests.
houkime added 14 commits 2022-10-31 19:04:26 +02:00
81efc19e74 Remove old cloudflare apiKey field from system test jsons 
Strangely, no test were broken. Probably more testing is needed for
token-dependent methods.
inex requested changes 2022-11-01 12:48:48 +02:00
selfprivacy_api/migrations/__init__.py Outdated
@ -26,2 +27,4 @@
MountVolume(),
CheckForFailedBindsMigration(),
CreateProviderFields(),
inex commented 2022-11-01 12:42:35 +02:00
Owner

Please reformat code with black . before commiting final version

Please reformat code with `black .` before commiting final version
houkime commented 2022-11-02 15:55:43 +02:00
Poster
Collaborator

addressed

addressed
houkime marked this conversation as resolved
selfprivacy_api/migrations/__init__.py Outdated
@ -45,6 +48,7 @@ def run_migrations():
return
for migration in migrations:
print ("starting migration:", migration)
inex commented 2022-11-01 12:42:58 +02:00
Owner

Please remove this print in final revision

Please remove this print in final revision
houkime commented 2022-11-02 15:56:16 +02:00
Poster
Collaborator

addressed

addressed
houkime marked this conversation as resolved
selfprivacy_api/rest/services.py Outdated
@ -265,3 +266,3 @@
@router.put("/restic/backblaze/config")
async def set_backblaze_config(backblaze_config: BackblazeConfigInput):
async def set_backblaze_config(backup_config: BackupConfigInput):
inex commented 2022-11-01 12:45:36 +02:00
Owner

This is a breaking API change.

REST API is deprecated and should keep the same interface until we delete it. Here, we should use the original API model and just imply (hardcode) backblaze.

This is a breaking API change. REST API is deprecated and should keep the same interface until we delete it. Here, we should use the original API model and just imply (hardcode) backblaze.
houkime commented 2022-11-02 15:58:56 +02:00
Poster
Collaborator

I kept the backup internal name since it does not technically change the interface. Please tell me if it is not ok.

I kept the `backup` internal name since it does not technically change the interface. Please tell me if it is not ok.
houkime commented 2022-11-02 15:59:52 +02:00
Poster
Collaborator

I did hardcode backblaze and no longer require the provider field as requested.

I did hardcode backblaze and no longer require the provider field as requested.
houkime marked this conversation as resolved
tests/test_rest_endpoints/services/test_restic.py Outdated
@ -459,3 +461,3 @@
response = authorized_client.put(
"/services/restic/backblaze/config",
json={"accountId": "123", "accountKey": "456", "bucket": "789"},
json={"provider": "IDRIVE", "accountId": "123", "accountKey": "456", "bucket": "789"},
inex commented 2022-11-01 12:48:27 +02:00
Owner

The client won't have this input updated, we should test without provider field.

GraphQL will have the interface for the provider.

The client won't have this input updated, we should test without provider field. GraphQL will have the interface for the provider.
houkime commented 2022-11-02 16:00:32 +02:00
Poster
Collaborator

addressed, also see above

addressed, also see above
houkime marked this conversation as resolved
houkime force-pushed houkime-providers-api from c1db1f67e9 to 41e5f89b7b 2022-11-02 15:54:17 +02:00 Compare
houkime requested review from inex 2022-11-02 16:00:59 +02:00
inex approved these changes 2022-11-02 16:19:10 +02:00
inex changed title from WIP: houkime-providers-api to houkime-providers-api 2022-11-02 17:35:16 +02:00
inex merged commit 9ee0240bbd into redis/connection-pool 2022-11-02 17:35:59 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
inex
Labels
Clear labels   
Bug
   
Contributions welcome
   
Did not do
   
Duplicate
   
Feature
  
Module
Backups
   
Module
GraphQL
  
Priority
High
   
Priority
Low
   
Priority
Medium
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
No Label
Bug
Contributions welcome
Did not do
Duplicate
Feature
Module
Backups
Module
GraphQL
Priority
High
Priority
Low
Priority
Medium
Refactor
Severity
High
Severity
Low
Severity
Medium
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy-rest-api#19
There is no content yet.
Delete Branch "houkime/selfprivacy-rest-api:houkime-providers-api"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?