WIP: feat: Use redis as a data storage for auth data #40

Closed

inex wants to merge 0 commits from redis/connection-pool into master

inex commented

2023-06-14 14:01:45 +03:00

Owner

There is no content yet.

inex added 67 commits 2023-06-14 14:01:46 +03:00

d930426f25 test(tokens-repo): make empty_keys fixture (and derived) shareable

1768fe278a test(tokens-repo): make empty_tokens fixture, even more minimal

40d331d01f test(tokens-repo): offload empty_keys fixture to json tests

cee0419a52 test(tokens-repo): remove test tokens.json files

except for one which will temporarily remain
gitkeeps are to prevent shared_datadir from erroring out in a freshly
cloned repo. for now huey database and jobs fixtures use shared_datadir

c5dc09d5dd test(tokens-repo): break out assert_original() in rest

5812b57ced test(tokens-repo): break out rest_get_token_info()

7b5fb4b2df test(tokens-repo): use rest token info in token deletion test

cb46c5e43b test(tokens-repo): check refreshed token validity by trying to auth

243f9be225 test(tokens-repo): delete standalone get new device test

At rest api level, we can only check the existence of new device token
by using it, and this test already exists.

51cc35708e test(tokens-repo): break out getting new device token

8b19c9c013 test(tokens-repo): break out checking token validity

6dd724b682 test(tokens-repo): make new device tests a bit more readable

5bf7e81351 test(tokens-repo): travel in time to check expiration

d55232735d test(tokens-repo): fix typo in contets

b526e0b6ad test(tokens-repo): do not read json in generate recovery test

2a577aedb7 test(tokens-repo): break out obtaining recovery tokens

38f9eb825a test(tokens-repo): break out recovery time operations

b254e40961 test(tokens-repo): break out recovery token use

fc24290f1c test(tokens-repo): use new recovery functions

406f5ee921 test(tokens-repo): use mock time for recovery tokens expiration test

a252c11e7d test(tokens-repo): allow ading uses in a helper recovery function

cd1afb8464 test(tokens-repo): refactor the rest of auth tests

2f0a7c35f3 test(tokens-repo): beautify test_auth.py

d3c337853e fix(tokens-repo): readd gitkeep to services data folder after rebase

7a27af9173 test(tokens-repo): new assert_original(), no more json

91bbc3520b test(tokens-repo): make shared test token state use token repo api for loading

710ad7221b refactor(tokens-repo): delete a stray comment

d84b4e9ad6 Merge pull request 'Token backend-agnostic rest API testing' (#31 ) from redis/rest-tests into redis/connection-pool

Reviewed-on: #31

33b53cb320 Merge branch 'master' into redis/connection-pool

a8d91a7a63 test(tokens-repo): delete extraneous test token content copies

70c82cf142 test(tokens-repo): break out assert_original() in graphql device tests

c597850fa5 test(tokens-repo): untie token deletion tests from json

4582bfe6c4 test(tokens-repo): break out assert_ok() and assert_errorcode() in graphql

c917c411fd test(tokens-repo): break out assert_empty()

e5083c308a test(tokens-repo): break out assert_data()

e7f0d76001 test(tokens-repo): apply assert_ok and assert_error()

37fd3574a1 test(tokens-repo): make sure we try to delete the token we authed with

74c36afc2d test(tokens-repo): untie refresh token testing from token repo

e9934a2567 test(tokens-repo): delete get new device key standalone test

we can only see if device key is valid by using it or deleting it.
another test does it

ff6128b96e test(tokens-repo): untie get and delete new device from json

93b02752df test(tokens-repo): untie authorize new device from json

c7222fd8b9 test(tokens-repo): untie double new device auth from json

a0bd3eb0ff test(tokens-repo): shrink invalid new device test

e537dd5f45 test(tokens-repo): move timewarping to test commons

3e641b1107 test(tokens-repo): complete untying graphql device tests from json

8d15955124 test(tokens-repo): use assert_empty consistently

88508985c9 test(tokens-repo): break out getting status

f742c256d7 test(tokens-repo): break out getting recovery key

b6dff04f42 test(tokens-repo): use assert recent

5382558655 test(tokens-repo): use get recovery status in test of recovery use

0160f4aac0 test(tokens-repo): break out using recovery key

6b6cc33b8e test(tokens-repo): move token utils to graphql common

8e1e917bff test(tokens-repo): check for token existense in recovery tests

5280aca544 test(tokens-repo): rework expiring recovery key tests

59f5ec2e2e test(tokens-repo): rework recovery expiration in the past

c8ccd415fe test(tokens-repo): rework limited uses test

cf87b3590b test(tokens-repo): complete the recovery test rework

eba1f19a55 test(tokens-repo): cleanup recovery tests

dc13235332 test(tokens-repo): remove device order dependence from graphql test__api

c624529670 refactor(tokens-repo): switch token backend to redis

And use timezone-aware comparisons for expiry checks

a8ac9e7c64 refactor(tokens-repo): cleanup actions/api_tokens.py

496f0bc452 refactor(tokens-repo): move reset to AbstractTokensRepo

72681c5330 refactor(tokens-repo): break out storing recovery keys

c3d797b0ab refactor(tokens-repo): move create recovery key to abstract token repository

628d7ed4a8 fix(tokens-repo): make json _get_stored_new_device_key return tz-aware keys

4c61c874c4 feat(tokens-repo): add clone() method

d9b5710007 feat(tokens-repo): add migration of tokens to redis

inex force-pushed redis/connection-pool from 22135a4638 to c77191864e

2023-06-14 14:03:48 +03:00

Compare

inex requested review from houkime 2023-06-14 14:04:14 +03:00

inex commented

2023-06-14 14:33:02 +03:00

Poster

Owner

Token name hashing right now is broken: yields different hashes on different runs.

inex changed title from ~~feat: Use redis as a data storage for auth data~~ to WIP: feat: Use redis as a data storage for auth data

2023-06-14 14:33:14 +03:00

houkime added 1 commit 2023-06-21 15:19:31 +03:00

5be3c83952 fix(tokens-repo): persistent hashing

houkime commented

2023-06-21 15:33:50 +03:00

Collaborator

LGTM if it deploys. We will still need to keep json code around for the purposes of migration, but maybe there will be some official deprecation date.
Also note that merging this will create merge conflict with mutation groups. But hopefully this design makes for less shotgun surgery when doing this.

LGTM if it deploys. We will still need to keep json code around for the purposes of migration, but maybe there will be some official deprecation date. Also note that merging this will create merge conflict with mutation groups. But hopefully this design makes for less shotgun surgery when doing this.