SelfPrivacy
/
selfprivacy-rest-api
7
2
Fork 1
Code Issues 15 Pull Requests 4 Projects Releases 1 Wiki Activity

simplify autobackups tasking to avoid deadlocks #97

Merged
inex merged 7 commits from fix-autobackup-typing into master 2024-03-03 23:46:15 +02:00
Conversation 0 Commits 7 Files Changed 5
houkime commented 2024-02-23 20:20:21 +02:00
Collaborator
There is no content yet.
houkime added 1 commit 2024-02-23 20:20:21 +02:00
continuous-integration/drone/push Build is failing Details
09f424a3c7 fix(backups): simplify autobackups to avoid deadlocks
houkime added 1 commit 2024-02-23 20:37:51 +02:00
continuous-integration/drone/push Build is failing Details
9a3b7652bf fix(backups): finish the autobackup job
houkime changed title from simplify autobackups tasking to avoid deadlocks to WIP: simplify autobackups tasking to avoid deadlocks 2024-02-23 20:41:14 +02:00
houkime requested review from inex 2024-02-23 20:41:33 +02:00
inex requested changes 2024-03-01 02:37:38 +02:00
inex left a comment
Owner

Should this still be marked as a draft?

Should this still be marked as a draft?
selfprivacy_api/backup/jobs.py Outdated
@ -4,3 +4,3 @@
from selfprivacy_api.jobs import Jobs, Job, JobStatus
from selfprivacy_api.services.service import Service
from selfprivacy_api.services import get_service_by_id
from selfprivacy_api.services import get_service_by_id, get_all_services
inex commented 2024-03-01 02:31:42 +02:00
Owner

get_all_services is unused

get_all_services is unused
houkime marked this conversation as resolved
selfprivacy_api/backup/jobs.py Outdated
@ -39,0 +45,4 @@
pretty_service_list: str = ", ".join(service_names)
job = Jobs.add(
type_id=autobackup_job_type(),
name=f"Automatic backup",
inex commented 2024-03-01 02:32:33 +02:00
Owner

f-string without any placeholders

f-string without any placeholders
houkime marked this conversation as resolved
selfprivacy_api/backup/tasks.py Outdated
@ -15,6 +15,7 @@ from huey import crontab
from selfprivacy_api.services.service import Service
inex commented 2024-03-01 02:34:01 +02:00
Owner

Looks like Service is no longer used in this file

Looks like Service is no longer used in this file
houkime marked this conversation as resolved
tests/test_autobackup.py Outdated
@ -20,2 +20,3 @@
from selfprivacy_api.backup.jobs import autobackup_job_type
from tests.test_backup import backups
from tests.test_backup import backups, assert_job_finished
inex commented 2024-03-01 02:36:50 +02:00
Owner

A bunch of unused imports in this file:
automatic_backup
backups
only_dummy_service

A bunch of unused imports in this file: `automatic_backup` `backups` `only_dummy_service`
houkime commented 2024-03-01 15:57:58 +02:00
Poster
Collaborator

backups and dummy services are used, it is just pyflakes being strange

backups and dummy services are used, it is just pyflakes being strange
houkime marked this conversation as resolved
houkime force-pushed fix-autobackup-typing from 9a3b7652bf to f840a6e204 2024-03-01 15:59:05 +02:00 Compare
houkime added 1 commit 2024-03-01 16:01:28 +02:00
continuous-integration/drone/push Build is failing Details
7ccf495958 refactor(backups): remove excessive format-strings
houkime changed title from WIP: simplify autobackups tasking to avoid deadlocks to simplify autobackups tasking to avoid deadlocks 2024-03-01 16:01:43 +02:00
inex added 1 commit 2024-03-03 23:45:49 +02:00
continuous-integration/drone/push Build is failing Details
36d026a8ca style: Formatting
inex approved these changes 2024-03-03 23:46:00 +02:00
inex merged commit 0e94590420 into master 2024-03-03 23:46:15 +02:00
inex deleted branch fix-autobackup-typing 2024-03-03 23:46:15 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
inex
Labels
Clear labels   
Bug
   
Contributions welcome
   
Did not do
   
Duplicate
   
Feature
  
Module
Backups
   
Module
GraphQL
  
Priority
High
   
Priority
Low
   
Priority
Medium
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
No Label
Bug
Contributions welcome
Did not do
Duplicate
Feature
Module
Backups
Module
GraphQL
Priority
High
Priority
Low
Priority
Medium
Refactor
Severity
High
Severity
Low
Severity
Medium
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy-rest-api#97
There is no content yet.
Delete Branch "fix-autobackup-typing"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?