feat(backblaze): Include milliseconds since epoch to bucket name #403

													
				@ -66,2 +66,2 @@

				      String bucketName = 'selfprivacy-$domain-$serverId';

				      // If bucket name is too long, shorten it

				      String bucketName =

				          '$domain-$serverId-${DateTime.now().millisecondsSinceEpoch}';

inex commented

2023-12-03 19:49:51 +02:00

The milliseconds since epoch is 13 digits long right now. Our limit on the name is 49 letters. The server ID is 8-12 digits long. It is 26 letters left for the domain. I would propose to trim the domain to ~20 letters.

The milliseconds since epoch is 13 digits long right now. Our limit on the name is 49 letters. The server ID is 8-12 digits long. It is 26 letters left for the `domain`. I would propose to trim the domain to ~20 letters.

NaiJi commented

2023-12-03 19:53:57 +02:00

Poster

bucketName gets trimmed up to 49 characters after that. Could we rearrange it like '${DateTime.now().millisecondsSinceEpoch}-$serverId-$domain' then ?

So if we exceed 49 characters, the domain will get trimmed either way, as it's in the end

`bucketName` gets trimmed up to 49 characters after that. Could we rearrange it like `'${DateTime.now().millisecondsSinceEpoch}-$serverId-$domain'` then ? So if we exceed 49 characters, the domain will get trimmed either way, as it's in the end

inex commented

2023-12-03 19:56:29 +02:00

yes, we might do this as well

NaiJi marked this conversation as resolved

NaiJi added 1 commit 2023-12-03 19:59:01 +02:00

f6ded5399c refactor(backblaze): Move milliseconds since epoch to the beginning of bucket name

NaiJi requested review from inex 2023-12-03 19:59:14 +02:00

inex approved these changes 2023-12-03 20:02:42 +02:00

NaiJi added 1 commit 2023-12-03 20:03:12 +02:00

55d77b2144 Merge branch 'master' into better-bucket-name

NaiJi merged commit 4eb3dac101 into master

2023-12-03 20:03:18 +02:00