SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 75 Pull Requests 3 Projects 1 Releases 24 Wiki Activity

fix: Domain name overflows on the "Use this domain?" screen #422

Merged
inex merged 4 commits from fix_overflows_use_this_domain into master 2024-01-19 15:59:43 +02:00
Conversation 3 Commits 4 Files Changed 1
def commented 2024-01-12 18:23:23 +02:00
Collaborator

image

#408

![image](/attachments/b1551991-75c6-4fa1-aad1-457f4f1eb2e3) https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/408
image.png
35 KiB
def added 1 commit 2024-01-12 18:23:23 +02:00
def requested review from inex 2024-01-12 18:23:40 +02:00
def requested review from NaiJi 2024-01-12 18:23:40 +02:00
NaiJi approved these changes 2024-01-15 11:31:21 +02:00
lib/ui/pages/setup/initializing/domain_picker.dart Outdated
@ -150,4 +139,0 @@
],
if (state is Loaded) ...[
const SizedBox(height: 32),
BrandButton.filled(
NaiJi commented 2024-01-15 11:29:24 +02:00
Collaborator

What will happen on this page now if a user has only one domain?

What will happen on this page now if a user has only one domain?
def commented 2024-01-18 15:32:57 +02:00
Poster
Collaborator

its my fail, accidentally removed some of the code. returned

> its my fail, accidentally removed some of the code. returned
inex marked this conversation as resolved
lib/ui/pages/setup/initializing/domain_picker.dart
@ -130,4 +138,1 @@
],
if (state is Empty) ...[
const SizedBox(height: 30),
BrandButton.filled(
NaiJi commented 2024-01-15 11:29:41 +02:00
Collaborator

What will on this page happen now if a user has no domains?

What will on this page happen now if a user has no domains?
def commented 2024-01-18 15:32:37 +02:00
Poster
Collaborator

its my fail, accidentally removed some of the code. returned

its my fail, accidentally removed some of the code. returned
inex marked this conversation as resolved
NaiJi requested changes 2024-01-15 11:31:38 +02:00
NaiJi left a comment
Collaborator

missclicked on "Approve", see comments above. Buttons disappear when we have only one domain or no domains

image

image

missclicked on "Approve", see comments above. Buttons disappear when we have only one domain or no domains ![image](/attachments/87729d6b-24ec-4366-9aef-e8a2e4c5d7f5) ![image](/attachments/2add5737-ea6d-4e8b-9625-f9cda7cc7b89)
image.png
12 KiB
image.png
14 KiB
NaiJi commented 2024-01-15 11:36:05 +02:00
Collaborator

what does overflows use this domain mean? please check what you write in english with deepl 🙏

what does `overflows use this domain` mean? please check what you write in english with deepl 🙏
def changed title from fix: overflows use this domain to fix: fix overflows use this domain 2024-01-17 15:36:47 +02:00
def changed title from fix: fix overflows use this domain to fix: Domain name overflows on the "Use this domain?" screen 2024-01-17 15:37:19 +02:00
def self-assigned this 2024-01-17 15:47:14 +02:00
def added the
Bug
Priority
Low
Severity
Low
 labels 2024-01-17 15:47:29 +02:00
def changed title from fix: Domain name overflows on the "Use this domain?" screen to WIP: fix: Domain name overflows on the "Use this domain?" screen 2024-01-17 15:48:02 +02:00
def added 1 commit 2024-01-18 15:31:08 +02:00
def changed title from WIP: fix: Domain name overflows on the "Use this domain?" screen to fix: Domain name overflows on the "Use this domain?" screen 2024-01-18 15:31:45 +02:00
def added 1 commit 2024-01-18 15:31:48 +02:00
def commented 2024-01-18 15:40:10 +02:00
Poster
Collaborator

image
image
image

![image](/attachments/6f5f6947-29f7-4216-8d66-06d01792b54b) ![image](/attachments/2bd72c85-b475-4871-b509-16d2a2aa1df9) ![image](/attachments/268aba75-3820-489a-b9dc-5c002217bb6c)
image.png
51 KiB
image.png
52 KiB
image.png
37 KiB
def requested review from NaiJi 2024-01-18 15:41:19 +02:00
def commented 2024-01-18 15:41:55 +02:00
Poster
Collaborator

tested:

  • no domains
  • one domain
  • multi domains
tested: - no domains - one domain - multi domains
inex requested changes 2024-01-19 01:07:15 +02:00
lib/ui/pages/setup/initializing/domain_picker.dart Outdated
@ -128,0 +132,4 @@
overflow: TextOverflow.ellipsis,
maxLines: 1,
),
)
inex commented 2024-01-19 01:06:33 +02:00
Owner

Missing a required trailing comma. Check your linter before commiting.

Missing a required trailing comma. Check your linter before commiting.
inex commented 2024-01-19 15:38:19 +02:00
Owner

this fix is on me today

this fix is on me today
inex marked this conversation as resolved
inex added 1 commit 2024-01-19 15:38:11 +02:00
inex approved these changes 2024-01-19 15:38:33 +02:00
inex merged commit 98b715700a into master 2024-01-19 15:59:43 +02:00
inex deleted branch fix_overflows_use_this_domain 2024-01-19 15:59:43 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
NaiJi
inex
Labels
Clear labels   
Blocked

Issue that can't be resolved right now due to some circumstances   
Bug

Discovered issue that affects regular operation   
Contributions welcome
   
Did not do

Issue is not queued for resolution due to low priority or introduced difficulties during the resolution   
Errata

Known issue with available workaround   
Feature request

Functionality/usability enchansement   
Fixed

Issue resolved in one of the application/backend releases   
How To

Question, regarding product operation   
Invalid
   
Needs design

A sketch or detailed description of the feature look is wanted   
No resolution

Issue is not queued for resolution due to architecture pecularities
  
Priority
Critical
   
Priority
High
   
Priority
Low
   
Priority
Medium
  
Providers
Digital Ocean
Issues related to Digital Ocean REST API   
Providers
Hetzner
Issues related to Hetzner REST API
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
  
Source
Community
Feature requests and bugs reported on our support chats   
Source
Core Team
   
Source
Stakeholders
Kirill, NLnet, and others
  
Translations
   
Under investigation

Issue details are currently being investigated
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
def
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#422
There is no content yet.
Delete Branch "fix_overflows_use_this_domain"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?