SelfPrivacy
/
selfprivacy.org
7
1
Fork 5
Code Issues 11 Pull Requests 5 Releases Activity

Fix tab borders in docs #107

Merged
inex merged 10 commits from nevfy/selfprivacy.org:fix-tabs into master 2024-02-12 15:18:52 +02:00
Conversation 5 Commits 10 Files Changed 1
nevfy commented 2024-02-04 20:27:52 +02:00
Collaborator

Fixes #100

Fixes #100
nevfy added 2 commits 2024-02-04 20:27:53 +02:00
inex commented 2024-02-05 10:11:45 +02:00
Owner

image

Probably should change the background of the active tab to match the block? (or change the colors of the content)

Tab background is #ffffff
Content background is #f8f9fa

![image](/attachments/b11d15db-9b14-4f0b-a206-2dc835fc9113) Probably should change the background of the active tab to match the block? (or change the colors of the content) Tab background is `#ffffff` Content background is `#f8f9fa`
image.png
16 KiB
inex commented 2024-02-05 10:18:04 +02:00
Owner

Border color is also different.

Tab: rgb(222, 226, 230)
Content: rgba(0, 0, 0, 0.125)

Border color is also different. Tab: `rgb(222, 226, 230)` Content: `rgba(0, 0, 0, 0.125)`
nevfy added 2 commits 2024-02-05 20:29:34 +02:00
nevfy added 1 commit 2024-02-05 20:36:17 +02:00
nevfy commented 2024-02-05 20:36:41 +02:00
Poster
Collaborator

@inex Thank you, haven't noticed it on my screen. I changed all colors to be white and changed the style to remove borders completely.

@inex Thank you, haven't noticed it on my screen. I changed all colors to be white and changed the style to remove borders completely.
nevfy requested review from inex 2024-02-05 20:36:53 +02:00
inex commented 2024-02-06 15:41:41 +02:00
Owner

1dd43956f2 broke the tabs and they are mostly unclickable now.

https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org/commit/1dd43956f2655d165616f3aea38e7bba078abfa8 broke the tabs and they are mostly unclickable now.
nevfy added 1 commit 2024-02-06 17:44:47 +02:00
nevfy added 1 commit 2024-02-06 17:46:46 +02:00
inex approved these changes 2024-02-08 15:54:14 +02:00
inex commented 2024-02-08 15:54:29 +02:00
Owner

Unresolved conflict

Unresolved conflict
nevfy added 1 commit 2024-02-09 03:13:36 +02:00
nevfy added 1 commit 2024-02-09 03:15:28 +02:00
nevfy requested review from inex 2024-02-09 03:15:58 +02:00
inex requested changes 2024-02-09 11:45:04 +02:00
assets/scss/docsy_overrides.scss Outdated
@ -147,0 +183,4 @@
}
}
=======
inex commented 2024-02-09 11:45:02 +02:00
Owner

Leftovers from the merge, it doesn't build with these

Leftovers from the merge, it doesn't build with these
nevfy added 1 commit 2024-02-09 19:21:01 +02:00
nevfy requested review from inex 2024-02-09 19:23:32 +02:00
inex approved these changes 2024-02-12 15:18:38 +02:00
inex merged commit 174bcb1d4e into master 2024-02-12 15:18:52 +02:00
nevfy deleted branch fix-tabs 2024-04-10 16:14:06 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
inex
Labels
Clear labels   
Docs

Documentation contents issue
No Label
Docs
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org#107
There is no content yet.
Delete Branch "nevfy/selfprivacy.org:fix-tabs"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?