SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 75 Pull Requests 2 Projects 1 Releases 24 Wiki Activity

fix: Manage server deletion #155

Merged
NaiJi merged 2 commits from deletion-error into master 2022-12-23 12:12:56 +02:00
Conversation 0 Commits 2 Files Changed 8
NaiJi commented 2022-12-22 22:21:01 +02:00
Collaborator
  • Implement proper error handling for server deletion stages
  • Make snake bars appear with brief explanation on deletion errors
  • Fix Digital Ocean broken deletion (issue 154)
- Implement proper error handling for server deletion stages - Make snake bars appear with brief explanation on deletion errors - Fix Digital Ocean broken deletion ([issue 154](https://git.selfprivacy.org/kherel/selfprivacy.org.app/issues/154))
NaiJi added the
Bug
 label 2022-12-22 22:21:01 +02:00
NaiJi self-assigned this 2022-12-22 22:21:01 +02:00
NaiJi added 1 commit 2022-12-22 22:21:02 +02:00
41dc77103f feat: Implement error handling on server deletion 
Notify users when errors occured and handle application state accordingly
NaiJi requested review from inex 2022-12-22 22:21:21 +02:00
inex requested changes 2022-12-23 11:34:36 +02:00
lib/logic/api_maps/staging_options.dart Outdated
@ -5,3 +5,3 @@
/// Hardcode to 'true' in the middle of testing to not
/// get your domain banned by constant certificate renewal
static bool get stagingAcme => false;
static bool get stagingAcme => true;
inex commented 2022-12-23 11:33:45 +02:00
Owner

Not allowed on master.

Not allowed on master.
NaiJi marked this conversation as resolved
NaiJi force-pushed deletion-error from 7fad03492d to f64f741a76 2022-12-23 11:51:41 +02:00 Compare
NaiJi requested review from inex 2022-12-23 11:52:05 +02:00
inex approved these changes 2022-12-23 12:05:12 +02:00
NaiJi merged commit 86cd12803a into master 2022-12-23 12:12:56 +02:00
NaiJi deleted branch deletion-error 2022-12-23 12:12:56 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
inex
Labels
Clear labels   
Blocked

Issue that can't be resolved right now due to some circumstances   
Bug

Discovered issue that affects regular operation   
Contributions welcome
   
Did not do

Issue is not queued for resolution due to low priority or introduced difficulties during the resolution   
Errata

Known issue with available workaround   
Feature request

Functionality/usability enchansement   
Fixed

Issue resolved in one of the application/backend releases   
How To

Question, regarding product operation   
Invalid
   
Needs design

A sketch or detailed description of the feature look is wanted   
No resolution

Issue is not queued for resolution due to architecture pecularities
  
Priority
Critical
   
Priority
High
   
Priority
Low
   
Priority
Medium
  
Providers
Digital Ocean
Issues related to Digital Ocean REST API   
Providers
Hetzner
Issues related to Hetzner REST API
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
  
Source
Community
Feature requests and bugs reported on our support chats   
Source
Core Team
   
Source
Stakeholders
Kirill, NLnet, and others
  
Translations
   
Under investigation

Issue details are currently being investigated
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
NaiJi
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#155
There is no content yet.
Delete Branch "deletion-error"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?