Merge pull request 'fix: Don't let start service migration if the same volume was picked' (#293) from service-migration into master
continuous-integration/drone/push Build is passing Details

Reviewed-on: #293
Reviewed-by: Inex Code <inex.code@selfprivacy.org>
pull/269/head^2
NaiJi ✨ 2023-08-11 18:30:39 +03:00
commit 8f30c3a4ba
1 changed files with 47 additions and 32 deletions

View File

@ -55,6 +55,20 @@ class _ServicesMigrationPageState extends State<ServicesMigrationPage> {
});
}
bool get isVolumePicked {
bool isChangeFound = false;
for (final Service service in widget.services) {
for (final String serviceId in serviceToDisk.keys) {
if (serviceId == service.id &&
serviceToDisk[serviceId] != service.storageUsage.volume!) {
isChangeFound = true;
}
}
}
return isChangeFound;
}
/// Check the services and if a service is moved (in a serviceToDisk entry)
/// subtract the used storage from the old volume and add it to the new volume.
/// The old volume is the volume the service is currently on, shown in services list.
@ -157,6 +171,7 @@ class _ServicesMigrationPageState extends State<ServicesMigrationPage> {
),
),
const SizedBox(height: 16),
if (widget.isMigration || (!widget.isMigration && isVolumePicked))
BrandButton.filled(
child: Text('storage.start_migration_button'.tr()),
onPressed: () {