SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 75 Pull Requests 3 Projects 1 Releases 24 Wiki Activity

refactor(ui): Move service card name to its icon row #352

Merged
NaiJi merged 5 commits from service-card-naming into master 2023-09-26 17:58:27 +03:00
Conversation 0 Commits 5 Files Changed 1
NaiJi commented 2023-09-18 18:25:54 +03:00
Collaborator

image

- Resolves https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/350 ![image](/attachments/7661af4f-1304-44ae-98bc-8cb29aac24e7)
image.png
80 KiB
NaiJi added the
Refactor
Severity
Low
 labels 2023-09-18 18:25:54 +03:00
NaiJi self-assigned this 2023-09-18 18:25:54 +03:00
NaiJi added 1 commit 2023-09-18 18:25:55 +03:00
NaiJi requested review from inex 2023-09-18 18:26:00 +03:00
NaiJi added 1 commit 2023-09-18 18:30:05 +03:00
NaiJi added 1 commit 2023-09-18 18:34:18 +03:00
inex requested changes 2023-09-18 18:36:52 +03:00
lib/ui/pages/services/services.dart Outdated
@ -129,17 +129,17 @@ class _Card extends StatelessWidget {
),
),
),
const SizedBox(width: 10),
inex commented 2023-09-18 18:36:46 +03:00
Owner

Try not to use values of 10 in paddings, it is not consistent with Material Design spec. We should use values that can be divided by 8 (or 4). Like 8, 16, 24, 32.

I want to note that we actually should also take into account the UI density set by device (desktop screens with mice are more dense than phones with touchscreens), and in the end it will be something like 8 * theme_density_multiplier. Right now you should use 8 or 16.

Try not to use values of 10 in paddings, it is not consistent with Material Design spec. We should use values that can be divided by 8 (or 4). Like 8, 16, 24, 32. I want to note that we actually should also take into account the UI density set by device (desktop screens with mice are more dense than phones with touchscreens), and in the end it will be something like 8 * theme_density_multiplier. Right now you should use 8 or 16.
NaiJi commented 2023-09-18 18:38:08 +03:00
Poster
Collaborator

Should I change all other (SizedBox: 10) in this component to 8 or 16?

Should I change all other (SizedBox: 10) in this component to 8 or 16?
inex commented 2023-09-18 18:39:21 +03:00
Owner

Yes, these may be remains from the kherel era. Don't forget to take a look how it looks in the end.

Yes, these may be remains from the kherel era. Don't forget to take a look how it looks in the end.
NaiJi commented 2023-09-18 18:44:13 +03:00
Poster
Collaborator

image

![image](/attachments/e4fcd223-db53-42a4-a0d4-32f9253b3e24)
NaiJi marked this conversation as resolved
NaiJi added 1 commit 2023-09-18 18:40:00 +03:00
NaiJi added 1 commit 2023-09-18 18:42:53 +03:00
NaiJi requested review from inex 2023-09-18 18:44:19 +03:00
inex approved these changes 2023-09-26 17:42:40 +03:00
NaiJi merged commit a83e1e0056 into master 2023-09-26 17:58:27 +03:00
NaiJi deleted branch service-card-naming 2023-09-26 17:58:27 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
inex
Labels
Clear labels   
Blocked

Issue that can't be resolved right now due to some circumstances   
Bug

Discovered issue that affects regular operation   
Contributions welcome
   
Did not do

Issue is not queued for resolution due to low priority or introduced difficulties during the resolution   
Errata

Known issue with available workaround   
Feature request

Functionality/usability enchansement   
Fixed

Issue resolved in one of the application/backend releases   
How To

Question, regarding product operation   
Invalid
   
Needs design

A sketch or detailed description of the feature look is wanted   
No resolution

Issue is not queued for resolution due to architecture pecularities
  
Priority
Critical
   
Priority
High
   
Priority
Low
   
Priority
Medium
  
Providers
Digital Ocean
Issues related to Digital Ocean REST API   
Providers
Hetzner
Issues related to Hetzner REST API
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
  
Source
Community
Feature requests and bugs reported on our support chats   
Source
Core Team
   
Source
Stakeholders
Kirill, NLnet, and others
  
Translations
   
Under investigation

Issue details are currently being investigated
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
NaiJi
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#352
There is no content yet.
Delete Branch "service-card-naming"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?