refactor(ui): Move service card name to its icon row #352
No reviewers
Labels
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: SelfPrivacy/selfprivacy.org.app#352
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "service-card-naming"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
@ -129,17 +129,17 @@ class _Card extends StatelessWidget {
),
),
),
const SizedBox(width: 10),
Try not to use values of 10 in paddings, it is not consistent with Material Design spec. We should use values that can be divided by 8 (or 4). Like 8, 16, 24, 32.
I want to note that we actually should also take into account the UI density set by device (desktop screens with mice are more dense than phones with touchscreens), and in the end it will be something like 8 * theme_density_multiplier. Right now you should use 8 or 16.
Should I change all other (SizedBox: 10) in this component to 8 or 16?
Yes, these may be remains from the kherel era. Don't forget to take a look how it looks in the end.