SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 75 Pull Requests 3 Projects 1 Releases 24 Wiki Activity

UI_refactor/onboarding #444

Merged
inex merged 9 commits from misterfourtytwo/selfprivacy.org.app:UI_refactor/onboarding into master 2024-02-08 13:59:53 +02:00
Conversation 1 Commits 9 Files Changed 20
misterfourtytwo commented 2024-01-31 05:58:33 +02:00

rewrote OnboardingPage:

  • decomposed into separate widgets
  • now content stays centered on wide screens (set so width won't expand further than 480px)
  • pageController is now properly disposed
rewrote OnboardingPage: * decomposed into separate widgets * now content stays centered on wide screens (set so width won't expand further than 480px) * pageController is now properly disposed
misterfourtytwo added 6 commits 2024-01-31 05:58:33 +02:00
misterfourtytwo requested review from inex 2024-01-31 06:21:41 +02:00
inex reviewed 2024-01-31 06:34:21 +02:00
analysis_options.yaml Outdated
@ -33,3 +33,3 @@
always_put_control_body_on_new_line: true
always_put_required_named_parameters_first: true
always_use_package_imports: true
always_use_package_imports: false
inex commented 2024-01-31 06:34:17 +02:00
Owner

Please, do not disable our lints

Please, do not disable our lints
inex marked this conversation as resolved
misterfourtytwo force-pushed UI_refactor/onboarding from db9e46a9a3 to 0d177d784c 2024-02-05 12:51:14 +02:00 Compare
misterfourtytwo commented 2024-02-05 13:02:40 +02:00
Poster
  • rebased on latest master branch
  • returned alwaysusepackageimports lint
  • added some more code changes to
    • main (error widget builder)
    • brand_header (centerTitle instead of empty actions list)
    • console_page (listener callback fix, used gaps instead of SizedBox'es, added keys to list items)
    • service_page (just cleaner build method)
    • removed some dead code
* rebased on latest master branch * returned *alwaysusepackageimports* lint * added some more code changes to * main (error widget builder) * brand_header (centerTitle instead of empty actions list) * console_page (listener callback fix, used gaps instead of SizedBox'es, added keys to list items) * service_page (just cleaner build method) * removed some dead code
misterfourtytwo force-pushed UI_refactor/onboarding from 0d177d784c to 208f93a319 2024-02-05 13:52:12 +02:00 Compare
NaiJi requested review from NaiJi 2024-02-05 17:40:32 +02:00
inex merged commit dd81053f42 into master 2024-02-08 13:59:53 +02:00
inex refused to review 2024-02-08 13:59:58 +02:00
inex removed review request for NaiJi 2024-02-08 13:59:59 +02:00
misterfourtytwo deleted branch UI_refactor/onboarding 2024-02-11 19:02:15 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Blocked

Issue that can't be resolved right now due to some circumstances   
Bug

Discovered issue that affects regular operation   
Contributions welcome
   
Did not do

Issue is not queued for resolution due to low priority or introduced difficulties during the resolution   
Errata

Known issue with available workaround   
Feature request

Functionality/usability enchansement   
Fixed

Issue resolved in one of the application/backend releases   
How To

Question, regarding product operation   
Invalid
   
Needs design

A sketch or detailed description of the feature look is wanted   
No resolution

Issue is not queued for resolution due to architecture pecularities
  
Priority
Critical
   
Priority
High
   
Priority
Low
   
Priority
Medium
  
Providers
Digital Ocean
Issues related to Digital Ocean REST API   
Providers
Hetzner
Issues related to Hetzner REST API
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
  
Source
Community
Feature requests and bugs reported on our support chats   
Source
Core Team
   
Source
Stakeholders
Kirill, NLnet, and others
  
Translations
   
Under investigation

Issue details are currently being investigated
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#444
There is no content yet.
Delete Branch "misterfourtytwo/selfprivacy.org.app:UI_refactor/onboarding"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?