UI_refactor/onboarding #444

Merged
inex merged 9 commits from misterfourtytwo/selfprivacy.org.app:UI_refactor/onboarding into master 2024-02-08 13:59:53 +02:00

rewrote OnboardingPage:

  • decomposed into separate widgets
  • now content stays centered on wide screens (set so width won't expand further than 480px)
  • pageController is now properly disposed
rewrote OnboardingPage: * decomposed into separate widgets * now content stays centered on wide screens (set so width won't expand further than 480px) * pageController is now properly disposed
misterfourtytwo added 2 commits 2024-01-31 05:58:33 +02:00
misterfourtytwo requested review from inex 2024-01-31 06:21:41 +02:00
inex reviewed 2024-01-31 06:34:21 +02:00
@ -33,3 +33,3 @@
always_put_control_body_on_new_line: true
always_put_required_named_parameters_first: true
always_use_package_imports: true
always_use_package_imports: false

Please, do not disable our lints

Please, do not disable our lints
inex marked this conversation as resolved
misterfourtytwo force-pushed UI_refactor/onboarding from db9e46a9a3 to 0d177d784c 2024-02-05 12:51:14 +02:00 Compare
  • rebased on latest master branch
  • returned alwaysusepackageimports lint
  • added some more code changes to
    • main (error widget builder)
    • brand_header (centerTitle instead of empty actions list)
    • console_page (listener callback fix, used gaps instead of SizedBox'es, added keys to list items)
    • service_page (just cleaner build method)
    • removed some dead code
* rebased on latest master branch * returned *alwaysusepackageimports* lint * added some more code changes to * main (error widget builder) * brand_header (centerTitle instead of empty actions list) * console_page (listener callback fix, used gaps instead of SizedBox'es, added keys to list items) * service_page (just cleaner build method) * removed some dead code
misterfourtytwo force-pushed UI_refactor/onboarding from 0d177d784c to 208f93a319 2024-02-05 13:52:12 +02:00 Compare
NaiJi requested review from NaiJi 2024-02-05 17:40:32 +02:00
inex merged commit dd81053f42 into master 2024-02-08 13:59:53 +02:00
inex refused to review 2024-02-08 13:59:58 +02:00
inex removed review request for NaiJi 2024-02-08 13:59:59 +02:00
misterfourtytwo deleted branch UI_refactor/onboarding 2024-02-11 19:02:15 +02:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#444
There is no content yet.