SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 75 Pull Requests 3 Projects 1 Releases 24 Wiki Activity

refactor(ui): Make users be ordered properly on users page #343

Merged
NaiJi merged 3 commits from users-order into master 2023-09-18 18:32:57 +03:00
Conversation 1 Commits 3 Files Changed 3
NaiJi commented 2023-09-16 07:19:45 +03:00
Collaborator
- Resolves [340](https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/340)
NaiJi added the
Refactor
Severity
Low
 labels 2023-09-16 07:19:45 +03:00
NaiJi self-assigned this 2023-09-16 07:19:45 +03:00
NaiJi commented 2023-09-16 07:21:37 +03:00
Poster
Collaborator

image

![image](/attachments/c6e12ce4-aad4-425c-8b4a-fd5cbe6ef59c)
image.png
12 KiB
NaiJi requested review from inex 2023-09-16 07:23:31 +03:00
NaiJi added the
Priority
Low
 label 2023-09-16 07:23:41 +03:00
NaiJi reviewed 2023-09-16 07:25:13 +03:00
lib/ui/pages/users/user.dart Outdated
@ -3,11 +3,11 @@ part of 'users.dart';
class _User extends StatelessWidget {
const _User({
required this.user,
required this.isRootUser,
NaiJi commented 2023-09-16 07:25:13 +03:00
Poster
Collaborator

Because it's NOT ROOT USER! We filter UserType.root away in the first place!

Because it's NOT ROOT USER! We filter UserType.root away in the first place!
NaiJi marked this conversation as resolved
NaiJi reviewed 2023-09-16 07:25:52 +03:00
lib/ui/pages/users/users.dart Outdated
@ -45,15 +45,7 @@ class UsersPage extends StatelessWidget {
} else {
child = BlocBuilder<UsersCubit, UsersState>(
builder: (final BuildContext context, final UsersState state) {
final List<User> users = state.users
NaiJi commented 2023-09-16 07:25:52 +03:00
Poster
Collaborator

Ordering is rather business logic, not UI

Ordering is rather business logic, not UI
NaiJi marked this conversation as resolved
NaiJi force-pushed users-order from 153c8b048d to 5c329d47c1 2023-09-16 08:09:52 +03:00 Compare
inex requested changes 2023-09-18 18:21:34 +03:00
lib/ui/pages/users/user.dart Outdated
@ -4,3 +4,3 @@
const _User({
required this.user,
required this.isRootUser,
required this.isUserPrimary,
inex commented 2023-09-18 18:21:15 +03:00
Owner

isPrimaryUser

isPrimaryUser
NaiJi marked this conversation as resolved
NaiJi added 1 commit 2023-09-18 18:27:35 +03:00
NaiJi requested review from inex 2023-09-18 18:28:05 +03:00
NaiJi added 1 commit 2023-09-18 18:28:55 +03:00
inex approved these changes 2023-09-18 18:32:25 +03:00
NaiJi merged commit d97d133479 into master 2023-09-18 18:32:57 +03:00
NaiJi deleted branch users-order 2023-09-18 18:32:57 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
inex
Labels
Clear labels   
Blocked

Issue that can't be resolved right now due to some circumstances   
Bug

Discovered issue that affects regular operation   
Contributions welcome
   
Did not do

Issue is not queued for resolution due to low priority or introduced difficulties during the resolution   
Errata

Known issue with available workaround   
Feature request

Functionality/usability enchansement   
Fixed

Issue resolved in one of the application/backend releases   
How To

Question, regarding product operation   
Invalid
   
Needs design

A sketch or detailed description of the feature look is wanted   
No resolution

Issue is not queued for resolution due to architecture pecularities
  
Priority
Critical
   
Priority
High
   
Priority
Low
   
Priority
Medium
  
Providers
Digital Ocean
Issues related to Digital Ocean REST API   
Providers
Hetzner
Issues related to Hetzner REST API
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
  
Source
Community
Feature requests and bugs reported on our support chats   
Source
Core Team
   
Source
Stakeholders
Kirill, NLnet, and others
  
Translations
   
Under investigation

Issue details are currently being investigated
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
NaiJi
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#343
There is no content yet.
Delete Branch "users-order"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?