SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 75 Pull Requests 2 Projects 1 Releases 24 Wiki Activity

refactor: Remove redundant zone id cache for Cloudflare #371

Merged
NaiJi merged 2 commits from cloudflare-caching into master 2023-10-06 23:37:35 +03:00
Conversation 0 Commits 2 Files Changed 1
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/logic/providers/dns_providers/cloudflare.dart
View File

@ -69,13 +69,6 @@ class CloudflareDnsProvider extends DnsProvider {
)
.toList();
/// TODO: Remove when domain selection for more than one domain on account is implemented, move cachedZoneId writing to domain saving method
_adapter = ApiAdapter(
isWithToken: true,
cachedDomain: result.data[0].name,
cachedZoneId: result.data[0].id,
NaiJi commented 2023-10-06 01:46:21 +03:00
Review

_adapter will receive cachedDomain and cachedZoneId from syncZoneId() anytime we call any method, so this hardcode is too much as we already have support for selection from several domains

`_adapter` will receive `cachedDomain` and `cachedZoneId` from `syncZoneId()` anytime we call any method, so this hardcode is too much as we already have support for selection from several domains
);
return GenericResult(
success: true,
data: domains,