SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 75 Pull Requests 3 Projects 1 Releases 24 Wiki Activity

feat: Add the button to copy password on the new user creation screen #409

Merged
inex merged 4 commits from add_copy_passwd_to_users into master 2023-12-28 15:19:17 +02:00
Conversation 2 Commits 4 Files Changed 1
def commented 2023-12-20 02:38:17 +02:00
Collaborator

image

#299

![image](/attachments/6918f987-6bd0-4e8f-9d2b-3124d7812ec1) https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/299
image.png
18 KiB
def added 1 commit 2023-12-20 02:38:17 +02:00
def requested review from NaiJi 2023-12-20 02:38:30 +02:00
def self-assigned this 2023-12-20 02:38:34 +02:00
def requested review from inex 2023-12-20 02:38:47 +02:00
NaiJi commented 2023-12-20 02:52:26 +02:00
Collaborator

Always add related links in commit messages.

git commit --amend -m "feat: add copy passwd to users" -m "- Resolve https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/299"

Gitea will link all the stuff automatically

Always add related links in commit messages. ``` git commit --amend -m "feat: add copy passwd to users" -m "- Resolve https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/299" ``` Gitea will link all the stuff automatically
NaiJi requested changes 2023-12-20 03:03:09 +02:00
NaiJi left a comment
Collaborator
There is no content yet.
image.png
12 KiB
image.png
lib/ui/pages/users/new_user.dart Outdated
@ -80,0 +86,4 @@
.password
.state
.value;
Clipboard.setData(
NaiJi commented 2023-12-20 02:56:34 +02:00
Collaborator

We have PlatformAdapter::setClipboard in lib/utils/platform_adapter.dart

We have `PlatformAdapter::setClipboard` in lib/utils/platform_adapter.dart
def commented 2023-12-20 03:39:29 +02:00
Poster
Collaborator

done

done
NaiJi marked this conversation as resolved
lib/ui/pages/users/new_user.dart Outdated
@ -80,0 +93,4 @@
IconButton(
icon: Icon(
Icons.refresh,
size: 30.0,
NaiJi commented 2023-12-20 03:02:53 +02:00
Collaborator

The buttons have different radius. You can also clearly see it when you tap them: one ink bubble is bigger than another.

image

The buttons have different radius. You can also clearly see it when you tap them: one ink bubble is bigger than another. ![image](/attachments/e26822d6-2958-4df3-9bc0-e946c542c694)
def commented 2023-12-20 04:01:48 +02:00
Poster
Collaborator

done

done
NaiJi marked this conversation as resolved
NaiJi added the
Feature request
Severity
Low
 labels 2023-12-20 03:05:44 +02:00
def force-pushed add_copy_passwd_to_users from 715d0555e8 to 4693ff325c 2023-12-20 03:25:17 +02:00 Compare
def added 1 commit 2023-12-20 04:01:39 +02:00
def requested review from NaiJi 2023-12-20 04:01:59 +02:00
NaiJi requested changes 2023-12-20 14:07:38 +02:00
NaiJi left a comment
Collaborator

Please pay attention to the output of flutter analyze and fix warnings related to your changes.

flutter analyze | grep users I guess

Please pay attention to the output of `flutter analyze` and fix warnings related to your changes. `flutter analyze | grep users` I guess
NaiJi requested changes 2023-12-20 14:31:41 +02:00
lib/ui/pages/users/new_user.dart Outdated
@ -80,0 +81,4 @@
.password
.state
.value;
PlatformAdapter.setClipboard(currentPassword);
NaiJi commented 2023-12-20 14:11:20 +02:00
Collaborator

Also we need to visually notify about the success, please refer to
lib/ui/pages/backups/snapshot_id_list_tile.dart

      getIt<NavigationService>().showSnackBar(
        'basis.copied_to_clipboard'.tr(),
        behavior: SnackBarBehavior.floating,
      );
Also we need to visually notify about the success, please refer to lib/ui/pages/backups/snapshot_id_list_tile.dart ``` getIt<NavigationService>().showSnackBar( 'basis.copied_to_clipboard'.tr(), behavior: SnackBarBehavior.floating, ); ```
def commented 2023-12-22 03:33:18 +02:00
Poster
Collaborator

done

done
lib/ui/pages/users/new_user.dart Outdated
@ -80,0 +100,4 @@
padding: EdgeInsets.all(8.0),
child: Icon(
Icons.refresh,
size: 30.0,
NaiJi commented 2023-12-20 14:30:07 +02:00
Collaborator

Material Icons are standardized in size, you don't need to adjust it manually with InkWell and other things. It would be enough to set them back to IconButton class with Icon size 24.0.

We need to be rather conventional than subjective, because otherwise it adds up more unneeded complexity, even if we disagree with Flutter.

Material Icons are standardized in size, you don't need to adjust it manually with InkWell and other things. It would be enough to set them back to IconButton class with Icon size 24.0. We need to be rather conventional than subjective, because otherwise it adds up more unneeded complexity, even if we disagree with Flutter.
NaiJi commented 2023-12-20 14:33:07 +02:00
Collaborator

I guess Flutter does that because of some effect or idk

I guess Flutter does that because of [some effect or idk](https://medium.com/design-bridges/optical-effects-9fca82b4cd9a)
def added 1 commit 2023-12-22 03:33:13 +02:00
def requested review from NaiJi 2023-12-22 03:33:31 +02:00
def added 1 commit 2023-12-22 03:34:05 +02:00
NaiJi commented 2023-12-22 12:02:01 +02:00
Collaborator

Fix linter warnings:

flutter analyze | grep users
Fix linter warnings: ``` flutter analyze | grep users ```
NaiJi requested changes 2023-12-22 12:02:20 +02:00
NaiJi left a comment
Collaborator

Linter

Linter
inex requested changes 2023-12-22 12:47:29 +02:00
inex left a comment
Owner

Unresolved linter issues:

warning • lib/ui/pages/users/users.dart:28:8 • Duplicate import. Try removing all but one import of the library. • duplicate_import
   info • lib/ui/pages/users/new_user.dart:84:31 • Local variables should be final. Try making the variable final. • prefer_final_locals
Unresolved linter issues: ``` warning • lib/ui/pages/users/users.dart:28:8 • Duplicate import. Try removing all but one import of the library. • duplicate_import info • lib/ui/pages/users/new_user.dart:84:31 • Local variables should be final. Try making the variable final. • prefer_final_locals ```
def changed title from feat: add copy passwd to users to feat: add copy password button to new users screen 2023-12-22 21:04:16 +02:00
def added 2 commits 2023-12-22 21:40:04 +02:00
def requested review from inex 2023-12-22 21:40:14 +02:00
def requested review from NaiJi 2023-12-22 21:40:17 +02:00
NaiJi approved these changes 2023-12-23 11:01:31 +02:00
inex changed title from feat: add copy password button to new users screen to feat: Add the button to copy password on the new user creation screen 2023-12-23 11:21:02 +02:00
inex approved these changes 2023-12-28 15:18:50 +02:00
inex force-pushed add_copy_passwd_to_users from bf5ab541e9 to 5fb9eec696 2023-12-28 15:18:58 +02:00 Compare
inex merged commit e3e5570e4e into master 2023-12-28 15:19:17 +02:00
inex deleted branch add_copy_passwd_to_users 2023-12-28 15:19:17 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
NaiJi
inex
Labels
Clear labels   
Blocked

Issue that can't be resolved right now due to some circumstances   
Bug

Discovered issue that affects regular operation   
Contributions welcome
   
Did not do

Issue is not queued for resolution due to low priority or introduced difficulties during the resolution   
Errata

Known issue with available workaround   
Feature request

Functionality/usability enchansement   
Fixed

Issue resolved in one of the application/backend releases   
How To

Question, regarding product operation   
Invalid
   
Needs design

A sketch or detailed description of the feature look is wanted   
No resolution

Issue is not queued for resolution due to architecture pecularities
  
Priority
Critical
   
Priority
High
   
Priority
Low
   
Priority
Medium
  
Providers
Digital Ocean
Issues related to Digital Ocean REST API   
Providers
Hetzner
Issues related to Hetzner REST API
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
  
Source
Community
Feature requests and bugs reported on our support chats   
Source
Core Team
   
Source
Stakeholders
Kirill, NLnet, and others
  
Translations
   
Under investigation

Issue details are currently being investigated
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
def
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#409
There is no content yet.
Delete Branch "add_copy_passwd_to_users"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?