SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 75 Pull Requests 2 Projects 1 Releases 24 Wiki Activity

feat: add completed state for jobs widget #421

Closed
def wants to merge 10 commits from add_complated_state_for_jobs_widget into master
pull from: add_complated_state_for_jobs_widget
merge into: SelfPrivacy:master
Conversation 2 Commits 10 Files Changed 4
def commented 2024-01-10 16:30:27 +02:00
Collaborator

image

#254

![image](/attachments/3b79367c-38d4-4d32-ab48-3500c53e5c49) https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/254
image.png
11 KiB
def added 1 commit 2024-01-10 16:30:28 +02:00
def added 1 commit 2024-01-10 16:30:36 +02:00
def requested review from inex 2024-01-10 16:33:03 +02:00
def requested review from NaiJi 2024-01-10 16:33:03 +02:00
def added 1 commit 2024-01-10 17:02:37 +02:00
def added 1 commit 2024-01-10 17:18:14 +02:00
def added 1 commit 2024-01-10 17:23:55 +02:00
def added 1 commit 2024-01-10 17:26:28 +02:00
NaiJi requested changes 2024-01-15 11:21:25 +02:00
NaiJi left a comment
Collaborator

@inex need your mastermind knowledge of all UI specs

image

@inex need your mastermind knowledge of all UI specs ![image](/attachments/3ab5ca81-eccf-485e-97cb-74be91ec8f5d)
image.png
31 KiB
lib/logic/cubit/client_jobs/client_jobs_cubit.dart Outdated
@ -77,3 +77,3 @@
getIt<NavigationService>().showSnackBar('jobs.upgrade_failed'.tr());
}
emit(JobsStateEmpty());
emit(JobsCompleted());
NaiJi commented 2024-01-15 11:20:09 +02:00
Collaborator

Even if a job failed? 🗸 looks a bit misleading for an error.

Even if a job failed? 🗸 looks a bit misleading for an error.
def commented 2024-01-17 15:45:58 +02:00
Poster
Collaborator

done

done
inex marked this conversation as resolved
NaiJi changed title from feat: add complated state for jobs widget to feat: add completed state for jobs widget 2024-01-15 11:22:18 +02:00
def added 1 commit 2024-01-17 15:45:49 +02:00
def added 1 commit 2024-01-17 15:46:02 +02:00
def requested review from NaiJi 2024-01-17 15:46:07 +02:00
def added the
Feature request
Priority
Low
Severity
Low
 labels 2024-01-17 15:47:02 +02:00
def self-assigned this 2024-01-17 15:47:42 +02:00
inex requested changes 2024-01-19 01:04:35 +02:00
lib/logic/cubit/client_jobs/client_jobs_cubit.dart Outdated
@ -61,3 +61,3 @@
getIt<NavigationService>().showSnackBar('jobs.reboot_failed'.tr());
}
emit(JobsStateEmpty());
emit(JobsCompleted());
inex commented 2024-01-19 01:02:54 +02:00
Owner

I would suggest looking literally two lines above: the reboot request might fail. We shouldn't show that everything is ok in this case.

I would suggest looking literally two lines above: the reboot request might fail. We shouldn't show that everything is ok in this case.
lib/ui/components/jobs_content/jobs_content.dart Outdated
@ -45,0 +59,4 @@
'jobs.completed'.tr(),
style: Theme.of(context).textTheme.bodyLarge?.copyWith(
color: Theme.of(context).colorScheme.onSurface,
) ??
inex commented 2024-01-19 01:04:20 +02:00
Owner

No need for ?? const TextStyle(). style is totally fine with null, it has its own defaults.

No need for `?? const TextStyle()`. `style` is totally fine with `null`, it has its own defaults.
def added 1 commit 2024-01-19 17:07:00 +02:00
def added 1 commit 2024-01-19 17:08:44 +02:00
def requested review from inex 2024-01-19 17:08:59 +02:00
NaiJi approved these changes 2024-01-27 01:47:59 +02:00
def commented 2024-02-25 05:38:20 +02:00
Poster
Collaborator

@inex ?

@inex ?
inex commented 2024-02-26 13:37:22 +02:00
Owner

#440 solved this

#440 solved this
inex closed this pull request 2024-02-26 13:37:22 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
inex
NaiJi
Labels
Clear labels   
Blocked

Issue that can't be resolved right now due to some circumstances   
Bug

Discovered issue that affects regular operation   
Contributions welcome
   
Did not do

Issue is not queued for resolution due to low priority or introduced difficulties during the resolution   
Errata

Known issue with available workaround   
Feature request

Functionality/usability enchansement   
Fixed

Issue resolved in one of the application/backend releases   
How To

Question, regarding product operation   
Invalid
   
Needs design

A sketch or detailed description of the feature look is wanted   
No resolution

Issue is not queued for resolution due to architecture pecularities
  
Priority
Critical
   
Priority
High
   
Priority
Low
   
Priority
Medium
  
Providers
Digital Ocean
Issues related to Digital Ocean REST API   
Providers
Hetzner
Issues related to Hetzner REST API
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
  
Source
Community
Feature requests and bugs reported on our support chats   
Source
Core Team
   
Source
Stakeholders
Kirill, NLnet, and others
  
Translations
   
Under investigation

Issue details are currently being investigated
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
def
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#421
There is no content yet.
Delete Branch "add_complated_state_for_jobs_widget"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?