feat: Make DNS records deletion and creation dynamic #424

Merged
NaiJi merged 4 commits from dynamic-dns-deletion into master 2024-01-19 15:46:58 +02:00
Collaborator
  • Add selector._domainkey project record
  • Resolve #265
- Add `selector._domainkey` project record - Resolve https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/265
NaiJi added the
Feature request
Priority
High
Refactor
labels 2024-01-16 19:35:12 +02:00
NaiJi self-assigned this 2024-01-16 19:35:13 +02:00
NaiJi requested review from inex 2024-01-16 19:35:16 +02:00
inex force-pushed dynamic-dns-deletion from 6fe8400924 to 2836ce4870 2024-01-19 00:50:44 +02:00 Compare
inex requested changes 2024-01-19 01:00:27 +02:00
@ -124,0 +133,4 @@
/// Remove all records that do not match with SelfPrivacy
cloudflareRecords.removeWhere(
(final oceanRecord) => !selfprivacyRecords.any(

What is ocean?

What is `ocean`?
inex marked this conversation as resolved
@ -124,0 +125,4 @@
final DnsRecord txt3 = DnsRecord(
type: 'TXT',
name: 'selector._domainkey',
content: 'v=DKIM1; k=rsa; p=none',

We really shouldn't create empty DKIM records.

We really shouldn't create empty DKIM records.
Poster
Collaborator

We don't. Look at 143 line

We don't. Look at 143 line

Ah, so is it used only for deletion? Probably worth putting a comment about it.

Ah, so is it used only for deletion? Probably worth putting a comment about it.
inex marked this conversation as resolved
NaiJi added 1 commit 2024-01-19 15:23:14 +02:00
NaiJi requested review from inex 2024-01-19 15:23:43 +02:00
inex approved these changes 2024-01-19 15:36:11 +02:00
NaiJi merged commit dca733f641 into master 2024-01-19 15:46:58 +02:00
NaiJi deleted branch dynamic-dns-deletion 2024-01-19 15:46:58 +02:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#424
There is no content yet.