SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 75 Pull Requests 3 Projects 1 Releases 24 Wiki Activity

feat: Make DNS records deletion and creation dynamic #424

Merged
NaiJi merged 4 commits from dynamic-dns-deletion into master 2024-01-19 15:46:58 +02:00
Conversation 0 Commits 4 Files Changed 10
NaiJi commented 2024-01-16 19:35:12 +02:00
Collaborator
  • Add selector._domainkey project record
  • Resolve #265
- Add `selector._domainkey` project record - Resolve https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/265
NaiJi added the
Feature request
Priority
High
Refactor
 labels 2024-01-16 19:35:12 +02:00
NaiJi self-assigned this 2024-01-16 19:35:13 +02:00
NaiJi added 3 commits 2024-01-16 19:35:13 +02:00
NaiJi requested review from inex 2024-01-16 19:35:16 +02:00
inex force-pushed dynamic-dns-deletion from 6fe8400924 to 2836ce4870 2024-01-19 00:50:44 +02:00 Compare
inex requested changes 2024-01-19 01:00:27 +02:00
lib/logic/providers/dns_providers/cloudflare.dart Outdated
@ -124,0 +133,4 @@
/// Remove all records that do not match with SelfPrivacy
cloudflareRecords.removeWhere(
(final oceanRecord) => !selfprivacyRecords.any(
inex commented 2024-01-19 00:55:33 +02:00
Owner

What is ocean?

What is `ocean`?
inex marked this conversation as resolved
lib/utils/network_utils.dart
@ -124,0 +125,4 @@
final DnsRecord txt3 = DnsRecord(
type: 'TXT',
name: 'selector._domainkey',
content: 'v=DKIM1; k=rsa; p=none',
inex commented 2024-01-19 01:00:06 +02:00
Owner

We really shouldn't create empty DKIM records.

We really shouldn't create empty DKIM records.
NaiJi commented 2024-01-19 13:30:06 +02:00
Poster
Collaborator

We don't. Look at 143 line

We don't. Look at 143 line
inex commented 2024-01-19 13:35:58 +02:00
Owner

Ah, so is it used only for deletion? Probably worth putting a comment about it.

Ah, so is it used only for deletion? Probably worth putting a comment about it.
👍 1
inex marked this conversation as resolved
NaiJi added 1 commit 2024-01-19 15:23:14 +02:00
NaiJi requested review from inex 2024-01-19 15:23:43 +02:00
inex approved these changes 2024-01-19 15:36:11 +02:00
NaiJi merged commit dca733f641 into master 2024-01-19 15:46:58 +02:00
NaiJi deleted branch dynamic-dns-deletion 2024-01-19 15:46:58 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
inex
Labels
Clear labels   
Blocked

Issue that can't be resolved right now due to some circumstances   
Bug

Discovered issue that affects regular operation   
Contributions welcome
   
Did not do

Issue is not queued for resolution due to low priority or introduced difficulties during the resolution   
Errata

Known issue with available workaround   
Feature request

Functionality/usability enchansement   
Fixed

Issue resolved in one of the application/backend releases   
How To

Question, regarding product operation   
Invalid
   
Needs design

A sketch or detailed description of the feature look is wanted   
No resolution

Issue is not queued for resolution due to architecture pecularities
  
Priority
Critical
   
Priority
High
   
Priority
Low
   
Priority
Medium
  
Providers
Digital Ocean
Issues related to Digital Ocean REST API   
Providers
Hetzner
Issues related to Hetzner REST API
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
  
Source
Community
Feature requests and bugs reported on our support chats   
Source
Core Team
   
Source
Stakeholders
Kirill, NLnet, and others
  
Translations
   
Under investigation

Issue details are currently being investigated
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
NaiJi
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#424
There is no content yet.
Delete Branch "dynamic-dns-deletion"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?