SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 75 Pull Requests 3 Projects 1 Releases 24 Wiki Activity

feat: add route to service cards in storage page #446

Merged
inex merged 6 commits from feat_add_route_services_to_storage_page into master 2024-04-11 13:04:22 +03:00
Conversation 8 Commits 6 Files Changed 1
def commented 2024-02-04 01:38:41 +02:00
Collaborator
There is no content yet.
Screencast_20240204_033937.mp4
2.3 MiB
image.png
52 KiB
image.png
def added 1 commit 2024-02-04 01:38:42 +02:00
def requested review from inex 2024-02-04 01:38:48 +02:00
def requested review from NaiJi 2024-02-04 01:38:51 +02:00
def changed title from feat: add route to services in storage page to feat: add route to service cards in storage page 2024-02-04 01:41:10 +02:00
NaiJi requested changes 2024-02-04 08:58:21 +02:00
lib/ui/pages/server_storage/server_storage.dart Outdated
@ -136,3 +135,1 @@
colorFilter: ColorFilter.mode(
Theme.of(context).colorScheme.onBackground,
BlendMode.srcIn,
Widget build(BuildContext context) => GestureDetector(
NaiJi commented 2024-02-04 08:56:36 +02:00
Collaborator

BuildContext context -> final BuildContext context
Again, don't forget to check for warnings

`BuildContext context` -> `final BuildContext context` Again, don't forget to check for warnings
NaiJi commented 2024-02-04 08:57:50 +02:00
Collaborator

Better replace GestureDetector with InkWell (literally just replace the constructor call), since InkWell handles "hovering" over elements. cc @inex

Better replace `GestureDetector` with `InkWell` (literally just replace the constructor call), since `InkWell` handles "hovering" over elements. cc @inex
def commented 2024-02-05 02:01:24 +02:00
Poster
Collaborator

image

For some reason, the selection is square instead of rounded.

![image](/attachments/efb67200-c573-4b86-a374-b0d31323f019) For some reason, the selection is square instead of rounded.
image.png
16 KiB
def added 1 commit 2024-02-05 02:02:06 +02:00
def added 1 commit 2024-02-05 02:03:12 +02:00
def requested review from NaiJi 2024-02-05 02:03:18 +02:00
def self-assigned this 2024-02-05 02:04:19 +02:00
NaiJi approved these changes 2024-02-05 02:08:24 +02:00
misterfourtytwo commented 2024-02-05 13:08:08 +02:00

image

For some reason, the selection is square instead of rounded.

inkwell just paints whole allowed rectangle of material in defined color.
just provide borderRadius to it, or use ClipRRect around.

> ![image](/attachments/efb67200-c573-4b86-a374-b0d31323f019) > > > For some reason, the selection is square instead of rounded. inkwell just *paints* whole allowed rectangle of material in defined color. just provide borderRadius to it, or use ClipRRect around.
def changed title from feat: add route to service cards in storage page to WIP: feat: add route to service cards in storage page 2024-02-09 03:37:19 +02:00
def commented 2024-02-09 03:37:36 +02:00
Poster
Collaborator

image

For some reason, the selection is square instead of rounded.

inkwell just paints whole allowed rectangle of material in defined color.
just provide borderRadius to it, or use ClipRRect around.

thanks

> > ![image](/attachments/efb67200-c573-4b86-a374-b0d31323f019) > > > > > > For some reason, the selection is square instead of rounded. > > inkwell just *paints* whole allowed rectangle of material in defined color. > just provide borderRadius to it, or use ClipRRect around. thanks
def commented 2024-02-09 03:38:09 +02:00
Poster
Collaborator

i will replace all inkwell ^-^

i will replace all inkwell ^-^
inex commented 2024-02-09 11:53:36 +02:00
Owner

i will replace all inkwell ^-^

You don't have to replace it, just give it a border radius or wrap in a clipping widget.

> i will replace all inkwell ^-^ You don't have to replace it, just give it a border radius or wrap in a clipping widget.
def added 1 commit 2024-02-10 00:58:39 +02:00
def commented 2024-02-10 00:59:13 +02:00
Poster
Collaborator

image

![image](/attachments/f7ff63da-c28a-4010-8b6b-a409678547e3)
image.png
21 KiB
def commented 2024-02-10 00:59:41 +02:00
Poster
Collaborator

but I don't like the edges, they are very narrow and close to the icon

but I don't like the edges, they are very narrow and close to the icon
def changed title from WIP: feat: add route to service cards in storage page to feat: add route to service cards in storage page 2024-02-10 00:59:47 +02:00
def added 1 commit 2024-02-10 00:59:59 +02:00
def commented 2024-03-01 15:14:56 +02:00
Poster
Collaborator

image

![image](/attachments/74666cda-cd0c-4e62-8df6-8640cc13425a)
image.png
20 KiB
def added 1 commit 2024-03-01 15:16:17 +02:00
def added 1 commit 2024-03-01 15:16:30 +02:00
def requested review from NaiJi 2024-03-01 15:17:51 +02:00
inex self-assigned this 2024-03-28 15:37:22 +02:00
inex force-pushed feat_add_route_services_to_storage_page from 687a272f76 to ecb050e5aa 2024-04-11 12:52:19 +03:00 Compare
inex added 1 commit 2024-04-11 13:03:27 +03:00
inex merged commit 0dc281a4f6 into master 2024-04-11 13:04:22 +03:00
inex deleted branch feat_add_route_services_to_storage_page 2024-04-11 13:04:22 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
inex
NaiJi
Labels
Clear labels   
Blocked

Issue that can't be resolved right now due to some circumstances   
Bug

Discovered issue that affects regular operation   
Contributions welcome
   
Did not do

Issue is not queued for resolution due to low priority or introduced difficulties during the resolution   
Errata

Known issue with available workaround   
Feature request

Functionality/usability enchansement   
Fixed

Issue resolved in one of the application/backend releases   
How To

Question, regarding product operation   
Invalid
   
Needs design

A sketch or detailed description of the feature look is wanted   
No resolution

Issue is not queued for resolution due to architecture pecularities
  
Priority
Critical
   
Priority
High
   
Priority
Low
   
Priority
Medium
  
Providers
Digital Ocean
Issues related to Digital Ocean REST API   
Providers
Hetzner
Issues related to Hetzner REST API
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
  
Source
Community
Feature requests and bugs reported on our support chats   
Source
Core Team
   
Source
Stakeholders
Kirill, NLnet, and others
  
Translations
   
Under investigation

Issue details are currently being investigated
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
def
inex
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#446
There is no content yet.
Delete Branch "feat_add_route_services_to_storage_page"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?