SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 75 Pull Requests 3 Projects 1 Releases 24 Wiki Activity

feat: add copy link to service page #461

Merged
inex merged 10 commits from add_copy_link_to_service_page into master 2024-04-11 13:14:20 +03:00
Conversation 4 Commits 10 Files Changed 1
def commented 2024-02-09 03:10:10 +02:00
Collaborator

fix #452

image

fix https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/452 ![image](/attachments/566b6514-d3ab-41e7-80a6-df557bd264b7)
image.png
29 KiB
def added the
Feature request
Priority
Low
Severity
Low
Source
Core Team
 labels 2024-02-09 03:10:10 +02:00
def added 1 commit 2024-02-09 03:10:11 +02:00
def added 1 commit 2024-02-09 03:10:20 +02:00
def requested review from inex 2024-02-09 03:10:38 +02:00
def requested review from NaiJi 2024-02-09 03:10:38 +02:00
def self-assigned this 2024-02-09 03:10:53 +02:00
inex requested changes 2024-02-09 11:43:11 +02:00
inex left a comment
Owner

Please make it a long tap and not an icon

Please make it a long tap and not an icon
inex commented 2024-02-09 12:06:38 +02:00
Owner

On desktop, you could make a context menu on right-click.

On desktop, you could make a context menu on right-click.
def changed title from feat: add copy link to service page to WIP: feat: add copy link to service page 2024-02-10 00:24:17 +02:00
nevfy commented 2024-02-10 03:17:55 +02:00
Collaborator

Visible button is better for discoverability than long press and context menus. You can't know there is a long-tap gesture on an item until you click on random elements to find it. It is not obvious for how long do you need to hold on the button for the long-tap action to be activated.

It should be additional, but not the main way of interacting. I think both long-tap and a button are needed.

Current button placement is weird because it's size conflicts with the size of the icon of the main button.

Either:

  1. Create a separate full-size button,
  2. Make a smaller button nested into the main button so that icon sizes don't conflict; add the long-press gesture for power users.

First one should be easier to make and also looks cleaner.

Visible button is better for discoverability than long press and context menus. You can't know there is a long-tap gesture on an item until you click on random elements to find it. It is not obvious for how long do you need to hold on the button for the long-tap action to be activated. It should be additional, but not the main way of interacting. I think both long-tap and a button are needed. Current button placement is weird because it's size conflicts with the size of the icon of the main button. Either: 1) Create a separate full-size button, 2) Make a smaller button nested into the main button so that icon sizes don't conflict; add the long-press gesture for power users. First one should be easier to make and also looks cleaner.
2024_02_10_04_31_AdfdfdfdfdsdsdsdfdfMsdsd.png
33 KiB
2024_02_10_04_31_AdfdfdfdfdfdfM.png
31 KiB
2024_02_10_04_31_AdfdfdfM.png
32 KiB
2024_02_10_04_31_AdfdfdfdfdsdsdsdfdfMsdsd.png 2024_02_10_04_31_AdfdfdfdfdfdfM.png 2024_02_10_04_31_AdfdfdfM.png
def commented 2024-02-11 14:49:37 +02:00
Poster
Collaborator

thank u!

@inex

thank u! @inex
def added 2 commits 2024-02-28 21:10:26 +02:00
def added 1 commit 2024-02-28 21:12:29 +02:00
def changed title from WIP: feat: add copy link to service page to feat: add copy link to service page 2024-02-28 21:15:37 +02:00
def requested review from inex 2024-02-28 21:15:40 +02:00
def changed title from feat: add copy link to service page to WIP: feat: add copy link to service page 2024-03-01 15:00:46 +02:00
def added 1 commit 2024-03-01 15:00:53 +02:00
def changed title from WIP: feat: add copy link to service page to feat: add copy link to service page 2024-03-15 23:44:16 +02:00
def added 1 commit 2024-03-15 23:44:21 +02:00
def added 1 commit 2024-03-28 15:21:10 +02:00
def commented 2024-03-28 15:40:25 +02:00
Poster
Collaborator 
     GestureDetector - delete, use ListTile insted
GestureDetector - delete, use ListTile insted
def changed title from feat: add copy link to service page to WIP: feat: add copy link to service page 2024-03-28 15:40:32 +02:00
inex added 1 commit 2024-04-11 13:10:34 +03:00
inex added 1 commit 2024-04-11 13:13:44 +03:00
inex changed title from WIP: feat: add copy link to service page to feat: add copy link to service page 2024-04-11 13:13:50 +03:00
inex merged commit add2366e6b into master 2024-04-11 13:14:20 +03:00
inex deleted branch add_copy_link_to_service_page 2024-04-11 13:14:20 +03:00
inex removed review request for NaiJi 2024-04-11 13:14:47 +03:00
inex refused to review 2024-04-11 13:14:48 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
inex
Labels
Clear labels   
Blocked

Issue that can't be resolved right now due to some circumstances   
Bug

Discovered issue that affects regular operation   
Contributions welcome
   
Did not do

Issue is not queued for resolution due to low priority or introduced difficulties during the resolution   
Errata

Known issue with available workaround   
Feature request

Functionality/usability enchansement   
Fixed

Issue resolved in one of the application/backend releases   
How To

Question, regarding product operation   
Invalid
   
Needs design

A sketch or detailed description of the feature look is wanted   
No resolution

Issue is not queued for resolution due to architecture pecularities
  
Priority
Critical
   
Priority
High
   
Priority
Low
   
Priority
Medium
  
Providers
Digital Ocean
Issues related to Digital Ocean REST API   
Providers
Hetzner
Issues related to Hetzner REST API
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
  
Source
Community
Feature requests and bugs reported on our support chats   
Source
Core Team
   
Source
Stakeholders
Kirill, NLnet, and others
  
Translations
   
Under investigation

Issue details are currently being investigated
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
def
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#461
There is no content yet.
Delete Branch "add_copy_link_to_service_page"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?