feat(jobs): Implement garbage collection job #506
No reviewers
Labels
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: SelfPrivacy/selfprivacy.org.app#506
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "naiji/garbage-collection"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
@ -93,6 +93,11 @@ class JobsContent extends StatelessWidget {
);
},
),
const SizedBox(height: 10),
use
Gap
pleasewow we have that now?! letsgooooo
@ -95,1 +95,4 @@
),
const SizedBox(height: 10),
BrandButton.text(
onPressed: () => context.read<JobsCubit>().collectNixGarbage(),
onPressed: context.read<JobsCubit>().collectNixGarbage
It is better to place this button in the storage management screen, not on the Jobs screen. We don't want big emphasis on this feature.
@ -65,0 +74,4 @@
!jobs.any((final job) => job is CollectNixGarbageJob);
@override
Future<(bool, String)> execute() async => (false, 'unimplemented');
This is kinda a bad approach, as you're reusing code intended to be refactored out in the new code.
It would be better to make it a one-shot request to the API, and then our existing server-side jobs code will track it without any changes to it.