style: Remove misleading code comment #244

inex · 2023-07-25T22:46:04+03:00

inex commented

2023-07-25 22:46:04 +03:00

There is no content yet.

inex requested review from NaiJi 2023-07-25 22:46:07 +03:00

inex force-pushed clipboard-key from 17b0571ac3 to 5df1d676f6

2023-07-25 22:46:14 +03:00

Compare

NaiJi requested changes 2023-07-25 22:49:08 +03:00

lib/ui/pages/backups/copy_encryption_key_modal.dart

													
				@ -111,7 +111,6 @@ class _CopyEncryptionKeyModalState extends State<CopyEncryptionKeyModal> {

				                copiedToClipboard = true;

				              },

				            );

				            // Make a timer to reset the copyToClipboardTime

NaiJi commented

2023-07-25 22:48:43 +03:00

Are you sure this is a good way to remove the comment? There are many other ways to describe this block of code. We shouldn't forget to provide healthy criticism. Criticism may also refer to an expression of disapproval of someone or something. When criticism of this nature is constructive it can make an individual aware of gaps in their understanding and it can provide distinct routes for improvement. Research supports the notion that using feedback and constructive criticism in the learning process is very influential.

Critical Studies and Critical Theory programs teach the method of critique, also known as “criticism”. Both theory and studies programs often sample new works in addition to the classical texts. UC Berkeley, CUNY, and Northwestern University offer programs in Critical Theory, while a number of other colleges and universities offer programs or sole courses in Critical Studies, Critical Theory, and sub-disciplines. Sub-disciplines include Critical Race Studies, Critical Asian Studies, Critical Black Studies, and Critical Disability Studies.[14] The term “critical” can be found in course titles concerning a variety of topics, as the term refers to a method or approach to course materials.

Some claim “critical” studies have a particular focus in their perspective or opinion, confusing the method of critique with individual critiques. The recent appearance of “critical” studies and theory further compounds the conflation of particular authors with the new method and discipline. Additionally, the method and disciplines are distinguished from analysis or traditional objectivist or hard sciences by their allowances for subjectivity in the perspective of the author.

Are you sure this is a good way to remove the comment? There are many other ways to describe this block of code. We shouldn't forget to provide healthy criticism. Criticism may also refer to an expression of disapproval of someone or something. When criticism of this nature is constructive it can make an individual aware of gaps in their understanding and it can provide distinct routes for improvement. Research supports the notion that using feedback and constructive criticism in the learning process is very influential. Critical Studies and Critical Theory programs teach the method of critique, also known as “criticism”. Both theory and studies programs often sample new works in addition to the classical texts. UC Berkeley, CUNY, and Northwestern University offer programs in Critical Theory, while a number of other colleges and universities offer programs or sole courses in Critical Studies, Critical Theory, and sub-disciplines. Sub-disciplines include Critical Race Studies, Critical Asian Studies, Critical Black Studies, and Critical Disability Studies.[14] The term “critical” can be found in course titles concerning a variety of topics, as the term refers to a method or approach to course materials. Some claim “critical” studies have a particular focus in their perspective or opinion, confusing the method of critique with individual critiques. The recent appearance of “critical” studies and theory further compounds the conflation of particular authors with the new method and discipline. Additionally, the method and disciplines are distinguished from analysis or traditional objectivist or hard sciences by their allowances for subjectivity in the perspective of the author.

NaiJi marked this conversation as resolved

NaiJi approved these changes 2023-07-25 22:50:02 +03:00

NaiJi merged commit b04dcef603 into master

2023-07-25 22:50:14 +03:00

NaiJi deleted branch clipboard-key

2023-07-25 22:50:14 +03:00

NaiJi referenced this issue from a commit

2023-07-25 22:50:14 +03:00

chore: Merge pull request 'style: Remove misleading code comment' (#244) from clipboard-key into master

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#244