SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 75 Pull Requests 3 Projects 1 Releases 24 Wiki Activity

feat: Add animation to the recovery key screen #410

Merged
inex merged 3 commits from add_animation_recovery_menu into master 2023-12-26 11:28:53 +02:00
Conversation 0 Commits 3 Files Changed 1
def commented 2023-12-20 03:23:07 +02:00
Collaborator

#164

https://git.selfprivacy.org/SelfPrivacy/selfprivacy.org.app/issues/164
def added 1 commit 2023-12-20 03:23:08 +02:00
def force-pushed add_animation_recovery_menu from 30d372b45a to 40e09fcbbb 2023-12-20 03:24:05 +02:00 Compare
def requested review from inex 2023-12-20 03:25:40 +02:00
def requested review from NaiJi 2023-12-20 03:25:40 +02:00
def self-assigned this 2023-12-20 03:25:46 +02:00
def added the
Feature request
Severity
Low
 labels 2023-12-20 03:26:53 +02:00
NaiJi requested changes 2023-12-20 14:44:38 +02:00
lib/ui/pages/recovery_key/recovery_key.dart
@ -96,0 +94,4 @@
firstChild: keyStatus.exists && !_isConfigurationVisible
? RecoveryKeyInformation(state: keyStatus)
: const SizedBox.shrink(),
secondChild: _isConfigurationVisible || !keyStatus.exists
NaiJi commented 2023-12-20 14:44:35 +02:00
Collaborator

You already check the condition in crossFadeState.

. . . 
        AnimatedCrossFade(
          duration: const Duration(milliseconds: 300),
          firstChild: RecoveryKeyInformation(state: keyStatus),
          secondChild: const RecoveryKeyConfiguration(),
          crossFadeState: _isConfigurationVisible || !keyStatus.exists
              ? CrossFadeState.showSecond
              : CrossFadeState.showFirst,
        ),

https://api.flutter.dev/flutter/widgets/AnimatedCrossFade-class.html

You already check the condition in `crossFadeState`. ``` . . . AnimatedCrossFade( duration: const Duration(milliseconds: 300), firstChild: RecoveryKeyInformation(state: keyStatus), secondChild: const RecoveryKeyConfiguration(), crossFadeState: _isConfigurationVisible || !keyStatus.exists ? CrossFadeState.showSecond : CrossFadeState.showFirst, ), ``` https://api.flutter.dev/flutter/widgets/AnimatedCrossFade-class.html
def commented 2023-12-22 03:36:01 +02:00
Poster
Collaborator

done thx

done thx
NaiJi marked this conversation as resolved
def added 1 commit 2023-12-22 03:36:46 +02:00
def added 1 commit 2023-12-22 03:36:51 +02:00
def requested review from NaiJi 2023-12-22 03:36:54 +02:00
NaiJi approved these changes 2023-12-22 12:20:25 +02:00
def scheduled this pull request to auto merge when all checks succeed 2023-12-22 21:04:36 +02:00
def scheduled this pull request to auto merge when all checks succeed 2023-12-22 21:04:47 +02:00
def changed title from feat: add animation recovery menu to feat: add animation to recovery menu buttons 2023-12-22 21:21:57 +02:00
def changed title from feat: add animation to recovery menu buttons to feat: add animation to restore key menu 2023-12-22 21:24:37 +02:00
inex canceled auto merging this pull request when all checks succeed 2023-12-26 11:27:43 +02:00
inex changed title from feat: add animation to restore key menu to feat: Add animation to the recovery key screen 2023-12-26 11:28:06 +02:00
inex approved these changes 2023-12-26 11:28:21 +02:00
inex merged commit d7bf6a0c06 into master 2023-12-26 11:28:53 +02:00
inex deleted branch add_animation_recovery_menu 2023-12-26 11:28:53 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
NaiJi
inex
Labels
Clear labels   
Blocked

Issue that can't be resolved right now due to some circumstances   
Bug

Discovered issue that affects regular operation   
Contributions welcome
   
Did not do

Issue is not queued for resolution due to low priority or introduced difficulties during the resolution   
Errata

Known issue with available workaround   
Feature request

Functionality/usability enchansement   
Fixed

Issue resolved in one of the application/backend releases   
How To

Question, regarding product operation   
Invalid
   
Needs design

A sketch or detailed description of the feature look is wanted   
No resolution

Issue is not queued for resolution due to architecture pecularities
  
Priority
Critical
   
Priority
High
   
Priority
Low
   
Priority
Medium
  
Providers
Digital Ocean
Issues related to Digital Ocean REST API   
Providers
Hetzner
Issues related to Hetzner REST API
  
Refactor
  
Severity
High
   
Severity
Low
   
Severity
Medium
  
Source
Community
Feature requests and bugs reported on our support chats   
Source
Core Team
   
Source
Stakeholders
Kirill, NLnet, and others
  
Translations
   
Under investigation

Issue details are currently being investigated
No Label
Blocked
Bug
Contributions welcome
Did not do
Errata
Feature request
Fixed
How To
Invalid
Needs design
No resolution
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Providers
Digital Ocean
Providers
Hetzner
Refactor
Severity
High
Severity
Low
Severity
Medium
Source
Community
Source
Core Team
Source
Stakeholders
Translations
Under investigation
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
def
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: SelfPrivacy/selfprivacy.org.app#410
There is no content yet.
Delete Branch "add_animation_recovery_menu"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?