SelfPrivacy
/
selfprivacy.org.app
10
7
Fork 5
Code Issues 75 Pull Requests 2 Projects 1 Releases 24 Wiki Activity

feat: Add animation to the recovery key screen #410

Merged
inex merged 3 commits from add_animation_recovery_menu into master 2023-12-26 11:28:53 +02:00
Conversation 0 Commits 3 Files Changed 1
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/ui/pages/recovery_key/recovery_key.dart
View File

@ -89,10 +89,14 @@ class _RecoveryKeyContentState extends State<RecoveryKeyContent> {
children: [
if (keyStatus.exists) RecoveryKeyStatusCard(isValid: keyStatus.isValid),
const SizedBox(height: 16),
if (keyStatus.exists && !_isConfigurationVisible)
RecoveryKeyInformation(state: keyStatus),
if (_isConfigurationVisible || !keyStatus.exists)
const RecoveryKeyConfiguration(),
AnimatedCrossFade(
duration: const Duration(milliseconds: 300),
firstChild: RecoveryKeyInformation(state: keyStatus),
secondChild: const RecoveryKeyConfiguration(),
crossFadeState: _isConfigurationVisible || !keyStatus.exists
? CrossFadeState.showSecond
NaiJi marked this conversation as resolved
NaiJi commented 2023-12-20 14:44:35 +02:00
Review

You already check the condition in crossFadeState.

. . . 
        AnimatedCrossFade(
          duration: const Duration(milliseconds: 300),
          firstChild: RecoveryKeyInformation(state: keyStatus),
          secondChild: const RecoveryKeyConfiguration(),
          crossFadeState: _isConfigurationVisible || !keyStatus.exists
              ? CrossFadeState.showSecond
              : CrossFadeState.showFirst,
        ),

https://api.flutter.dev/flutter/widgets/AnimatedCrossFade-class.html

You already check the condition in `crossFadeState`. ``` . . . AnimatedCrossFade( duration: const Duration(milliseconds: 300), firstChild: RecoveryKeyInformation(state: keyStatus), secondChild: const RecoveryKeyConfiguration(), crossFadeState: _isConfigurationVisible || !keyStatus.exists ? CrossFadeState.showSecond : CrossFadeState.showFirst, ), ``` https://api.flutter.dev/flutter/widgets/AnimatedCrossFade-class.html
def commented 2023-12-22 03:36:01 +02:00
Review

done thx

done thx
: CrossFadeState.showFirst,
),
const SizedBox(height: 16),
if (!_isConfigurationVisible && keyStatus.isValid && keyStatus.exists)
BrandButton.text(